Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: src/IceTargetLowering.h

Issue 1472623002: Unify alloca, outgoing arg, and prolog construction (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Code review fixes. Also removed StackAdjustment. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceInstX86BaseImpl.h ('k') | src/IceTargetLoweringARM32.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLowering.h
diff --git a/src/IceTargetLowering.h b/src/IceTargetLowering.h
index bac403fd6bcfa86c7ac493ed7ccfa9437cb63558..dbfe669080cef8ddb94510ed6500069b98d1aeb4 100644
--- a/src/IceTargetLowering.h
+++ b/src/IceTargetLowering.h
@@ -221,9 +221,6 @@ public:
/// twice" attribute.
bool callsReturnsTwice() const { return CallsReturnsTwice; }
void setCallsReturnsTwice(bool RetTwice) { CallsReturnsTwice = RetTwice; }
- int32_t getStackAdjustment() const { return StackAdjustment; }
- void updateStackAdjustment(int32_t Offset) { StackAdjustment += Offset; }
- void resetStackAdjustment() { StackAdjustment = 0; }
SizeT makeNextLabelNumber() { return NextLabelNumber++; }
SizeT makeNextJumpTableNumber() { return NextJumpTableNumber++; }
LoweringContext &getContext() { return Context; }
@@ -251,17 +248,6 @@ public:
const llvm::SmallBitVector &ExcludeRegisters,
uint64_t Salt) const = 0;
- /// Save/restore any mutable state for the situation where code emission needs
- /// multiple passes, such as sandboxing or relaxation. Subclasses may provide
- /// their own implementation, but should be sure to also call the parent
- /// class's methods.
- virtual void snapshotEmitState() {
- SnapshotStackAdjustment = StackAdjustment;
- }
- virtual void rollbackEmitState() {
- StackAdjustment = SnapshotStackAdjustment;
- }
-
/// Get the minimum number of clusters required for a jump table to be
/// considered.
virtual SizeT getMinJumpTableSize() const = 0;
@@ -393,10 +379,6 @@ protected:
GlobalContext *Ctx;
bool HasComputedFrame = false;
bool CallsReturnsTwice = false;
- /// StackAdjustment keeps track of the current stack offset from its natural
- /// location, e.g. as arguments are pushed for a function call or as
- /// fixed-size alloca instructions are executed in the entry block.
- int32_t StackAdjustment = 0;
SizeT NextLabelNumber = 0;
SizeT NextJumpTableNumber = 0;
LoweringContext Context;
@@ -438,9 +420,6 @@ protected:
const static constexpr char *H_uitofp_i64_f64 = "__Sz_uitofp_i64_f64";
const static constexpr char *H_urem_i32 = "__umodsi3";
const static constexpr char *H_urem_i64 = "__umoddi3";
-
-private:
- int32_t SnapshotStackAdjustment = 0;
};
/// TargetDataLowering is used for "lowering" data including initializers for
« no previous file with comments | « src/IceInstX86BaseImpl.h ('k') | src/IceTargetLoweringARM32.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698