src/IceAssemblerARM32.cpp - Issue 1472623002: Unify alloca, outgoing arg, and prolog construction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceAssemblerARM32.cpp

Issue 1472623002: Unify alloca, outgoing arg, and prolog construction (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review fixes. Also removed StackAdjustment. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceAssemblerARM32.cpp

diff --git a/src/IceAssemblerARM32.cpp b/src/IceAssemblerARM32.cpp

index 29fcd027eb22e89466bb6254240a3db787fa23c6..4d13807c32db721abefac0d8e8f656ab778c9b96 100644

--- a/src/IceAssemblerARM32.cpp

+++ b/src/IceAssemblerARM32.cpp

@@ -296,11 +296,8 @@ DecodedResult decodeAddress(const Operand *Opnd, IValueT &Value,

if (!Utils::IsAbsoluteUint(12, Offset))

return CantDecode;

int32_t BaseRegNum = Var->getBaseRegNum();

- if (BaseRegNum == Variable::NoRegister) {

+ if (BaseRegNum == Variable::NoRegister)

BaseRegNum = TInfo.FrameOrStackReg;

- if (!TInfo.HasFramePointer)

- Offset += TInfo.StackAdjustment;

- }

Value = decodeImmRegOffset(decodeGPRRegister(BaseRegNum), Offset,

OperandARM32Mem::Offset);

return DecodedAsImmRegOffset;

« no previous file with comments | « src/IceAssemblerARM32.h ('k') | src/IceCfgNode.cpp » ('j') | no next file with comments »