Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1472483002: Check texture ids are valid in CopyTextureCHROMIUM apis. (Closed)

Created:
5 years, 1 month ago by vmiura
Modified:
5 years ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, reveman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check texture ids are valid in CopyTextureCHROMIUM apis. R=piman@chromium.org BUG=559357, 552075 Committed: https://crrev.com/9fe4e24070dec7c95b45b4eb0e4a6ef3317ed0a2 Cr-Commit-Position: refs/heads/master@{#362902}

Patch Set 1 #

Patch Set 2 : Rebase. Add checks to CompressedCopyTextureCHROMIUM apis too. #

Patch Set 3 : Correct error message. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -0 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 chunks +28 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_compressed_copy_texture_CHROMIUM_unittest.cc View 1 1 chunk +59 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
vmiura
ptal
5 years, 1 month ago (2015-11-20 23:32:35 UTC) #1
piman
lgtm
5 years, 1 month ago (2015-11-20 23:42:55 UTC) #2
vmiura
Added for CompressedCopyTextureCHROMIUM as well.
5 years, 1 month ago (2015-11-21 01:09:18 UTC) #5
piman
lgtm
5 years, 1 month ago (2015-11-21 01:10:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472483002/40001
5 years, 1 month ago (2015-11-21 01:21:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/138470)
5 years, 1 month ago (2015-11-21 02:36:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472483002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472483002/60001
5 years ago (2015-12-03 03:17:01 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-03 04:34:11 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-03 04:35:14 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9fe4e24070dec7c95b45b4eb0e4a6ef3317ed0a2
Cr-Commit-Position: refs/heads/master@{#362902}

Powered by Google App Engine
This is Rietveld 408576698