Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 1472473003: PPC: Fix object initialization when slack tracking for it's map is still enabled. (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Fix object initialization when slack tracking for it's map is still enabled. Port 2fc2cb99f52974d0743610189213a94585c30ac6 Original commit message: The old code was not ready for properly initialize objects with non standard headers and non zero in-object properties number. MacroAssembler::Allocate() implementations now return both start and end addresses of the new object (done by parameter renaming). R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/07b50849621348a7f1da4ce8600b68c094ebe900 Cr-Commit-Position: refs/heads/master@{#32182}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -68 lines) Patch
M src/ppc/builtins-ppc.cc View 2 chunks +16 lines, -32 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 2 chunks +11 lines, -11 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 6 chunks +25 lines, -25 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
MTBrandyberry
5 years, 1 month ago (2015-11-20 23:45:39 UTC) #1
Igor Sheludko
lgtm https://codereview.chromium.org/1472473003/diff/1/src/ppc/macro-assembler-ppc.cc File src/ppc/macro-assembler-ppc.cc (left): https://codereview.chromium.org/1472473003/diff/1/src/ppc/macro-assembler-ppc.cc#oldcode2892 src/ppc/macro-assembler-ppc.cc:2892: InitializeNFieldsWithFiller(start_offset, r0, filler); Does it make sense to ...
5 years, 1 month ago (2015-11-23 07:57:34 UTC) #2
michael_dawson
On 2015/11/23 07:57:34, Igor Sheludko wrote: > lgtm > > https://codereview.chromium.org/1472473003/diff/1/src/ppc/macro-assembler-ppc.cc > File src/ppc/macro-assembler-ppc.cc (left): ...
5 years, 1 month ago (2015-11-23 14:23:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472473003/1
5 years, 1 month ago (2015-11-23 14:38:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 15:09:54 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 15:10:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07b50849621348a7f1da4ce8600b68c094ebe900
Cr-Commit-Position: refs/heads/master@{#32182}

Powered by Google App Engine
This is Rietveld 408576698