Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Unified Diff: chrome/browser/dom_ui/tips_handler.h

Issue 147247: Remove null link from "welcome to tips" default suggestion. Also make some h... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/new_tab_ui.cc ('k') | chrome/browser/dom_ui/tips_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/tips_handler.h
===================================================================
--- chrome/browser/dom_ui/tips_handler.h (revision 19737)
+++ chrome/browser/dom_ui/tips_handler.h (working copy)
@@ -31,8 +31,8 @@
TipsHandler() : tips_cache_(NULL) {}
virtual ~TipsHandler() {}
- // DOMMessageHandler implementation and overrides.
- virtual DOMMessageHandler* Attach(DOMUI* dom_ui);
+ // DOMMessageHandler implementation and overrides.
+ virtual DOMMessageHandler* Attach(DOMUI* dom_ui);
virtual void RegisterMessages();
// Callback which pulls tips data from the preferences.
@@ -45,6 +45,9 @@
// Make sure the string we are pushing to the NTP is a valid URL.
bool IsValidURL(const std::wstring& url_string);
+ // So we can push data out to the page that has called this handler.
+ DOMUI* dom_ui_;
+
// Filled with data from cache in preferences.
const DictionaryValue* tips_cache_;
« no previous file with comments | « chrome/browser/dom_ui/new_tab_ui.cc ('k') | chrome/browser/dom_ui/tips_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698