Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 147246: Linux: middle-click to navigate (Closed)

Created:
11 years, 6 months ago by agl
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: middle-click to navigate At the request of several people, Ctrl-middle-clicking on an unused part of the page will now open a new foreground tab if the current selection is a valid URL.

Patch Set 1 #

Patch Set 2 : ... #

Total comments: 4

Patch Set 3 : ... #

Patch Set 4 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -37 lines) Patch
M chrome/browser/renderer_host/render_view_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.h View 2 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 1 2 3 4 chunks +26 lines, -6 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.h View 1 4 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 1 2 4 chunks +66 lines, -1 line 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webview_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/webview_impl.cc View 1 2 3 6 chunks +24 lines, -15 lines 0 comments Download
M webkit/glue/webwidget_impl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/webwidget_impl.cc View 1 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
agl
11 years, 6 months ago (2009-06-26 23:10:40 UTC) #1
tony
11 years, 6 months ago (2009-06-26 23:41:46 UTC) #2
LGTM, just some nits.

http://codereview.chromium.org/147246/diff/1001/1002
File chrome/browser/renderer_host/render_view_host.cc (right):

http://codereview.chromium.org/147246/diff/1001/1002#newcode1233
Line 1233: 
Nit: remove extra blank line

http://codereview.chromium.org/147246/diff/1001/1005
File chrome/browser/renderer_host/render_widget_host.cc (right):

http://codereview.chromium.org/147246/diff/1001/1005#newcode32
Line 32: using WebKit::WebMouseEvent;
Nit: This seems to be the same as 2 lines below.

http://codereview.chromium.org/147246/diff/1001/1007
File chrome/browser/tab_contents/tab_contents_view_gtk.cc (right):

http://codereview.chromium.org/147246/diff/1001/1007#newcode352
Line 352: gpointer arg) {
Can you use TabContentsViewGtk::ClipboardRequestCallback* instead of gpointer
here to avoid the reinterpret_cast below?

http://codereview.chromium.org/147246/diff/1001/1010
File webkit/glue/webview_impl.cc (right):

http://codereview.chromium.org/147246/diff/1001/1010#newcode519
Line 519: const bool processed =
This is const, the bool at line 459 isn't.  I'd probably just make them both
non-const.

Powered by Google App Engine
This is Rietveld 408576698