Issue 147245: Linux web drag first cut....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147245: Linux web drag first cut.... (Closed)

Created:
11 years, 6 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Linux web drag first cut. You can only drag out of the web contents, and can only drag text. http://crbug.com/15429 TEST=try dragging some text into gedit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19445

Patch Set 1 #

Patch Set 2 : more initing #

Patch Set 3 : connect once #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -7 lines)			Patch
	M	chrome/browser/tab_contents/tab_contents_view_gtk.h	View	1 2	3 chunks	+14 lines, -0 lines	1 comment	Download
	M	chrome/browser/tab_contents/tab_contents_view_gtk.cc	View	1 2	4 chunks	+47 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

I took a look at OSExchangeData (all stubbed out on linux atm), but it didn't ...

11 years, 6 months ago (2009-06-26 22:43:08 UTC) #1

tony

Do we need to keep connecting/disconnecting the signal handlers? Is it possible to just keep ...

11 years, 6 months ago (2009-06-26 23:06:21 UTC) #2

Evan Stade

On 2009/06/26 23:06:21, tony wrote: > Do we need to keep connecting/disconnecting the signal handlers? ...

11 years, 6 months ago (2009-06-26 23:16:25 UTC) #3

tony

11 years, 6 months ago (2009-06-26 23:55:18 UTC) #4

LGTM

http://codereview.chromium.org/147245/diff/1010/6
File chrome/browser/tab_contents/tab_contents_view_gtk.h (right):

http://codereview.chromium.org/147245/diff/1010/6#newcode100
Line 100: // Webkit DnD.
Nit: Renderer I think is more accurate.

Expand Messages | Collapse Messages