skia: Holding onto the image in the benchmark causes issues

skia: Holding onto the image in the benchmark causes issues

Skia'a nanobench can hold onto an image, that causes the lifetime
of GrGLGpu to extend past that of the GL interface.

Kill reference to surface and image before killing the interface

Committed: https://skia.googlesource.com/skia/+/4870e6d4c9ee76ee328969e82238c7adc371fd33

[hendrikw, 2015-11-20 22:53:54]

Description was changed from

==========
skia: Holding onto the image in the benchmark causes issues

Skia'a nanobench can hold onto an image, that causes the lifetime
of GrGLGpu to extend past that of the GL interface.

Kill reference to surface and image before killing the interface

BUG=skia:
==========

to

==========
skia: Holding onto the image in the benchmark causes issues

Skia'a nanobench can hold onto an image, that causes the lifetime
of GrGLGpu to extend past that of the GL interface.

Kill reference to surface and image before killing the interface
==========

[hendrikw, 2015-11-20 22:54:02]

PTAL, thanks!

[reed1, 2015-11-22 15:13:24]

reed@google.com changed reviewers:
+ bsalomon@google.com, mtklein@google.com, reed@google.com

[mtklein, 2015-11-23 22:13:04]

other than a note, this lgtm

https://codereview.chromium.org/1472433002/diff/1/bench/ImageBench.cpp
File bench/ImageBench.cpp (right):

https://codereview.chromium.org/1472433002/diff/1/bench/ImageBench.cpp#newcode43
bench/ImageBench.cpp:43: fRasterSurface.reset(nullptr);
let's add a note about why we do this proactively?

[hendrikw, 2015-11-23 22:51:58]

The CQ bit was checked by hendrikw@chromium.org

[hendrikw, 2015-11-23 22:51:59]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1472433002/#ps20001
(title: "add a comment")

[commit-bot: I haz the power, 2015-11-23 22:52:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1472433002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1472433002/20001

[commit-bot: I haz the power, 2015-11-24 13:50:26]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4870e6d4c9ee76ee328969e82238c7adc371fd33