Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1472423002: Revert of [turbofan] Introduce proper JSCreateLiteralRegExp operator. (Closed)

Created:
5 years ago by Igor Sheludko
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Introduce proper JSCreateLiteralRegExp operator. (patchset #2 id:20001 of https://codereview.chromium.org/1475973002/ ) Reason for revert: Broke "V8 Linux64 GC Stress - custom snapshot". http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/2824 Original issue's description: > [turbofan] Introduce proper JSCreateLiteralRegExp operator. > > This adds a new JavaScript level operator for regexp literal creation, > similar to what we already have for array and object literals. This > once gets lowered to a call to the FastCloneRegExpStub always. > > R=mstarzinger@chromium.org > > Committed: https://crrev.com/8659c5d1d287177369ce179a8d0b910192d840d9 > Cr-Commit-Position: refs/heads/master@{#32288} TBR=mstarzinger@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/168683d270d44f05f28acaf7d34c32d0250d2a4c Cr-Commit-Position: refs/heads/master@{#32292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -60 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +2 lines, -16 lines 0 comments Download
M src/compiler/js-operator.h View 2 chunks +7 lines, -9 lines 0 comments Download
M src/compiler/js-operator.cc View 3 chunks +4 lines, -17 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Igor Sheludko
Created Revert of [turbofan] Introduce proper JSCreateLiteralRegExp operator.
5 years ago (2015-11-25 18:15:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472423002/1
5 years ago (2015-11-25 18:15:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 18:15:47 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/168683d270d44f05f28acaf7d34c32d0250d2a4c Cr-Commit-Position: refs/heads/master@{#32292}
5 years ago (2015-11-25 18:16:27 UTC) #6
Michael Starzinger
I am pretty sure this reverts the wrong CL. If the waterfall stays red, then ...
5 years ago (2015-11-25 18:24:34 UTC) #7
Michael Achenbach
On 2015/11/25 18:24:34, Michael Starzinger wrote: > I am pretty sure this reverts the wrong ...
5 years ago (2015-11-25 18:25:34 UTC) #8
Benedikt Meurer
Yeah, that wasn't my CL.
5 years ago (2015-11-25 18:54:36 UTC) #9
Michael Achenbach
5 years ago (2015-11-25 19:13:24 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1478823002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Wrong revert..

Powered by Google App Engine
This is Rietveld 408576698