Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1472393002: Transition array should not know about write barrier internals. (Closed)

Created:
5 years ago by Hannes Payer (out of office)
Modified:
5 years ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Transition array should not know about write barrier internals. BUG= Committed: https://crrev.com/8f9a17f44f93b4ccdef76c76cb3e8c4c04618e49 Cr-Commit-Position: refs/heads/master@{#32297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -25 lines) Patch
M src/transitions.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/transitions.cc View 4 chunks +5 lines, -15 lines 0 comments Download
M src/transitions-inl.h View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Hannes Payer (out of office)
5 years ago (2015-11-25 17:00:59 UTC) #2
ulan
lgtm
5 years ago (2015-11-25 17:02:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472393002/1
5 years ago (2015-11-25 17:04:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 19:23:55 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-25 19:24:38 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8f9a17f44f93b4ccdef76c76cb3e8c4c04618e49
Cr-Commit-Position: refs/heads/master@{#32297}

Powered by Google App Engine
This is Rietveld 408576698