Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1472363002: VM: Inlining of small constructors/factories, optimizations on inlined function bodies (Closed)

Created:
5 years ago by Florian Schneider
Modified:
5 years ago
Reviewers:
rmacnak, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Inlining of small constructors/factories, optimizations on inlined function bodies Inline small constructors/factories more aggressively - the same way we already do for small getter/setter and certain operator methods. More local optimizations (ApplyClassIds) on inlined flow graphs with precompilation. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/d2ecf1d4211714569213baf7d5ca81a7491c226b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -10 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_inliner.h View 2 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 5 chunks +24 lines, -6 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
Florian Schneider
This CL eliminates e.g. the overhead of the phase parameters in constructors if they are ...
5 years ago (2015-11-25 15:49:56 UTC) #2
rmacnak
lgtm
5 years ago (2015-12-01 00:03:42 UTC) #3
Florian Schneider
Committed patchset #1 (id:1) manually as d2ecf1d4211714569213baf7d5ca81a7491c226b (presubmit successful).
5 years ago (2015-12-01 09:17:36 UTC) #5
srdjan
https://codereview.chromium.org/1472363002/diff/1/runtime/vm/flow_graph_optimizer.h File runtime/vm/flow_graph_optimizer.h (right): https://codereview.chromium.org/1472363002/diff/1/runtime/vm/flow_graph_optimizer.h#newcode19 runtime/vm/flow_graph_optimizer.h:19: explicit FlowGraphOptimizer( remove explicit
5 years ago (2015-12-01 16:36:26 UTC) #7
Florian Schneider
5 years ago (2015-12-02 12:52:19 UTC) #8
Message was sent while issue was closed.
Done.

https://codereview.chromium.org/1472363002/diff/1/runtime/vm/flow_graph_optim...
File runtime/vm/flow_graph_optimizer.h (right):

https://codereview.chromium.org/1472363002/diff/1/runtime/vm/flow_graph_optim...
runtime/vm/flow_graph_optimizer.h:19: explicit FlowGraphOptimizer(
On 2015/12/01 16:36:26, srdjan wrote:
> remove explicit

Thanks, done.

Powered by Google App Engine
This is Rietveld 408576698