Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issue 1472333003: Clean up Ganesh path render a little bit (Closed)

Created:
5 years ago by robertphillips
Modified:
5 years ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up Ganesh path render a little bit I'm not sure if this is an improvement but this is an attempt to start moving the handling of pathEffects up the call stack (ideally to SkGpuDevice). Note that the duplicate path sniffing in GrDrawContext::drawPath is still useful since it can be invoked if a path has to be explicitly drawn for a mask filter. Committed: https://skia.googlesource.com/skia/+/0e7029eaef917d314475dcc9df9df174af88de52

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Ooops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -44 lines) Patch
M src/gpu/GrBlurUtils.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 7 chunks +44 lines, -31 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 chunks +11 lines, -10 lines 0 comments Download
M src/gpu/SkGpuDevice_drawTexture.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
robertphillips
5 years ago (2015-11-25 20:19:05 UTC) #3
jvanverth1
lgtm
5 years ago (2015-11-25 20:32:46 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472333003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472333003/20001
5 years ago (2015-11-25 20:37:50 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472333003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472333003/40001
5 years ago (2015-11-25 20:52:09 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-25 22:36:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472333003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472333003/40001
5 years ago (2015-11-30 13:31:34 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-30 13:45:10 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0e7029eaef917d314475dcc9df9df174af88de52

Powered by Google App Engine
This is Rietveld 408576698