Chromium Code Reviews
Help | Chromium Project | Sign in
(33)

Issue 147233: Basic implentation of the client auth UI (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by jcampan
Modified:
4 years, 2 months ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com, darin (slow to review), Ben Goodger (Google)
Visibility:
Public.

Description

A first implementation of the SSL client auth UI.This uses the Windows API that prompts the user for a cert.R=wtcBUG=http://crbug.com/318TEST=Visit a site that requires client auth. A dialog to select a certificate should be shown. Try selecting no cert. Try again this time select a cert. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19456

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 30

Patch Set 4 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -16 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.h View 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 1 2 3 3 chunks +17 lines, -6 lines 0 comments Download
A chrome/browser/ssl/ssl_client_auth_handler.h View 1 2 3 1 chunk +60 lines, -0 lines 2 comments Download
A chrome/browser/ssl/ssl_client_auth_handler.cc View 1 2 3 1 chunk +100 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -8 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 5 (0 generated)
jcampan
6 years, 1 month ago (2009-06-26 21:23:05 UTC) #1
wtc
LGTM! http://codereview.chromium.org/147233/diff/1017/1018 File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/147233/diff/1017/1018#newcode2822 Line 2822: <!-- SSL client auth certificate selection dialog ...
6 years, 1 month ago (2009-06-26 21:53:32 UTC) #2
jcampan
I also removed the temporary auto-ssl-client-auth switch which is not user anymore. http://codereview.chromium.org/147233/diff/1017/1018 File chrome/app/generated_resources.grd ...
6 years, 1 month ago (2009-06-26 22:35:35 UTC) #3
wtc
LGTM. http://codereview.chromium.org/147233/diff/1029/26 File chrome/browser/ssl/ssl_client_auth_handler.h (right): http://codereview.chromium.org/147233/diff/1029/26#newcode30 Line 30: // Asks the user for a certificate ...
6 years, 1 month ago (2009-06-26 23:03:52 UTC) #4
wtc
6 years, 1 month ago (2009-06-27 01:42:48 UTC) #5
On 2009/06/26 22:35:35, jcampan wrote:
> I also removed the temporary auto-ssl-client-auth switch which is not user
> anymore.

I just logged in again to remind you to do this, and am happy
to see that you already did it :-)  For some reason I didn't
notice this comment this afternoon.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5