Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1472323002: [es6] Correct parsing of regular expression literal flags. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix oversight in interpreter Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug/debug.h" 10 #include "src/debug/debug.h"
(...skipping 1370 matching lines...) Expand 10 before | Expand all | Expand 10 after
1381 } 1381 }
1382 } 1382 }
1383 } 1383 }
1384 1384
1385 1385
1386 void FullCodeGenerator::VisitRegExpLiteral(RegExpLiteral* expr) { 1386 void FullCodeGenerator::VisitRegExpLiteral(RegExpLiteral* expr) {
1387 Comment cmnt(masm_, "[ RegExpLiteral"); 1387 Comment cmnt(masm_, "[ RegExpLiteral");
1388 __ mov(edi, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset)); 1388 __ mov(edi, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));
1389 __ Move(eax, Immediate(Smi::FromInt(expr->literal_index()))); 1389 __ Move(eax, Immediate(Smi::FromInt(expr->literal_index())));
1390 __ Move(ecx, Immediate(expr->pattern())); 1390 __ Move(ecx, Immediate(expr->pattern()));
1391 __ Move(edx, Immediate(expr->flags())); 1391 __ Move(edx, Immediate(Smi::FromInt(expr->flags())));
1392 FastCloneRegExpStub stub(isolate()); 1392 FastCloneRegExpStub stub(isolate());
1393 __ CallStub(&stub); 1393 __ CallStub(&stub);
1394 context()->Plug(eax); 1394 context()->Plug(eax);
1395 } 1395 }
1396 1396
1397 1397
1398 void FullCodeGenerator::EmitAccessor(ObjectLiteralProperty* property) { 1398 void FullCodeGenerator::EmitAccessor(ObjectLiteralProperty* property) {
1399 Expression* expression = (property == NULL) ? NULL : property->value(); 1399 Expression* expression = (property == NULL) ? NULL : property->value();
1400 if (expression == NULL) { 1400 if (expression == NULL) {
1401 __ push(Immediate(isolate()->factory()->null_value())); 1401 __ push(Immediate(isolate()->factory()->null_value()));
(...skipping 3469 matching lines...) Expand 10 before | Expand all | Expand 10 after
4871 Assembler::target_address_at(call_target_address, 4871 Assembler::target_address_at(call_target_address,
4872 unoptimized_code)); 4872 unoptimized_code));
4873 return OSR_AFTER_STACK_CHECK; 4873 return OSR_AFTER_STACK_CHECK;
4874 } 4874 }
4875 4875
4876 4876
4877 } // namespace internal 4877 } // namespace internal
4878 } // namespace v8 4878 } // namespace v8
4879 4879
4880 #endif // V8_TARGET_ARCH_IA32 4880 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698