Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1472293002: Make sure that NormalizeElements and ShouldConvertToFastElements are based on the same values (Closed)

Created:
5 years ago by Toon Verwaest
Modified:
5 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make sure that NormalizeElements and ShouldConvertToFastElements are based on the same values BUG=v8:4518 LOG=n Committed: https://crrev.com/066747ea053012a99e0cd3e20f36b8ed053b2124 Cr-Commit-Position: refs/heads/master@{#32265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M src/elements.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Toon Verwaest
ptal
5 years ago (2015-11-25 09:59:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472293002/1
5 years ago (2015-11-25 10:08:25 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-25 11:07:31 UTC) #6
Jakob Kummerow
lgtm
5 years ago (2015-11-25 11:43:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472293002/1
5 years ago (2015-11-25 11:44:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 11:46:41 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-25 11:46:56 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/066747ea053012a99e0cd3e20f36b8ed053b2124
Cr-Commit-Position: refs/heads/master@{#32265}

Powered by Google App Engine
This is Rietveld 408576698