Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1472273003: shell_util: Move RegistryEntry methods out-of-line. (Closed)

Created:
5 years ago by Matt Giuca
Modified:
5 years ago
Reviewers:
gab
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

shell_util: Move RegistryEntry methods out-of-line. This just moves the method definitions outside of the class declaration, in preparation for a future refactoring. No code changes. BUG=419972 Committed: https://crrev.com/ad1d113951f33a68deafd817132abd8668cf909e Cr-Commit-Position: refs/heads/master@{#362011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+508 lines, -428 lines) Patch
M chrome/installer/util/shell_util.cc View 13 chunks +508 lines, -428 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
Matt Giuca
The first part of splitting up https://codereview.chromium.org/623903002/. Although it is impossible to have the code ...
5 years ago (2015-11-25 06:07:27 UTC) #2
Matt Giuca
5 years ago (2015-11-25 06:07:52 UTC) #4
gab
On 2015/11/25 06:07:27, Matt Giuca wrote: > The first part of splitting up https://codereview.chromium.org/623903002/. > ...
5 years ago (2015-11-27 16:00:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472273003/1
5 years ago (2015-11-27 16:00:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 16:45:34 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-27 16:47:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad1d113951f33a68deafd817132abd8668cf909e
Cr-Commit-Position: refs/heads/master@{#362011}

Powered by Google App Engine
This is Rietveld 408576698