Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 1472273002: X87: [runtime] Pass closure to %CreateArrayLiteral and %CreateObjectLiteral. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Pass closure to %CreateArrayLiteral and %CreateObjectLiteral. port 1b1db13549c0631d50373cfc646a70e1f5d2e32b (r32220) original commit message: Change the runtime entries and their associated code stubs for object and array literal creation to take the closure instead of the raw literals pointer. This is way easier to deal with (and cleaner) in TurboFan. BUG= Committed: https://crrev.com/08071597ce9fd8d6972a3f0623c14a56944133c1 Cr-Commit-Position: refs/heads/master@{#32244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years ago (2015-11-25 04:46:26 UTC) #2
Weiliang
lgtm
5 years ago (2015-11-25 05:33:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472273002/1
5 years ago (2015-11-25 05:33:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 05:55:27 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-25 05:56:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08071597ce9fd8d6972a3f0623c14a56944133c1
Cr-Commit-Position: refs/heads/master@{#32244}

Powered by Google App Engine
This is Rietveld 408576698