Avoid RefPtr churn

Avoid RefPtr churn

This is a speculative fix for 560890, but seems like it might be a
good idea anyway. We have a reference to the thing having a
reference. No need to add another reference on top of that.

In the process drop a null check in StyleFetchedImageSet::image(),
ImageResource::image always returns an Image object. If nothing else
the Image::nullImage().

BUG=560890
Committed: https://crrev.com/f0753f059b3f14463deb64144dd0034352c725d5
Cr-Commit-Position: refs/heads/master@{#361640}

[davve, 2015-11-25 11:25:51]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-25 11:26:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1472253003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1472253003/1

[davve, 2015-11-25 12:35:23]

davve@opera.com changed reviewers:
+ fmalita@gmail.com, fs@opera.com

[davve, 2015-11-25 12:35:23]

Yes, it's a bit unlikely this is visible on any real site but the regression is
small and I have no other leads at the moment.

[davve, 2015-11-25 12:36:10]

Description was changed from

==========
Avoid RefPtr churn

This is a speculative fix for 560890, but seems like it might be a
good idea anyway. We have a reference to the thing having a
reference. No need to add another reference on top of that.

In the process drop a null check in StyleFetchedImageSet::image(),
ImageResource::image always returns an Image object. If nothing else
the Image::nullImage().

BUG=560890
==========

to

==========
Avoid RefPtr churn

This is a speculative fix for 560890, but seems like it might be a
good idea anyway. We have a reference to the thing having a
reference. No need to add another reference on top of that.

In the process drop a null check in StyleFetchedImageSet::image(),
ImageResource::image always returns an Image object. If nothing else
the Image::nullImage().

BUG=560890
==========

[davve, 2015-11-25 12:36:10]

davve@opera.com changed reviewers:
+ fmalita@chromium.org
- fmalita@gmail.com

[fs, 2015-11-25 12:46:39]

lgtm

[f(malita), 2015-11-25 13:11:53]

lgtm

[commit-bot: I haz the power, 2015-11-25 13:20:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 13:20:02]

Dry run: This issue passed the CQ dry run.

[davve, 2015-11-25 13:26:44]

The CQ bit was checked by davve@opera.com

[commit-bot: I haz the power, 2015-11-25 13:27:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1472253003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1472253003/1

[commit-bot: I haz the power, 2015-11-25 13:35:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-25 13:36:33]

Patchset 1 (id:??) landed as
https://crrev.com/f0753f059b3f14463deb64144dd0034352c725d5
Cr-Commit-Position: refs/heads/master@{#361640}