Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1472203002: Fix broken js closure in network_list.js (Closed)

Created:
5 years ago by fqj
Modified:
5 years ago
Reviewers:
stevenjb, michaelpg
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix broken js closure in network_list.js BUG= Committed: https://crrev.com/c0070e34397dda810c03cb103b1839006038a0bd Cr-Commit-Position: refs/heads/master@{#361515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/options/chromeos/network_list.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
fqj
PTAL.
5 years ago (2015-11-24 21:51:25 UTC) #2
stevenjb
lgtm (assuming the closure compiler runs locally :) )
5 years ago (2015-11-24 23:28:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472203002/1
5 years ago (2015-11-24 23:29:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 01:27:40 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c0070e34397dda810c03cb103b1839006038a0bd Cr-Commit-Position: refs/heads/master@{#361515}
5 years ago (2015-11-25 01:28:38 UTC) #8
michaelpg
5 years ago (2015-11-25 01:31:28 UTC) #9
Message was sent while issue was closed. 
lgtm2, thanks

Powered by Google App Engine
This is Rietveld 408576698