Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 14722005: Remove unused method and de-virtualize others in Element.h (Closed)

Created:
7 years, 7 months ago by Chris Evans
Modified:
7 years, 7 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews
Visibility:
Public.

Description

Remove unused method and de-virtualize others in Element.h The de-virtualization possibilities were noted whilst "FINALizing" the Node hierarchy. If a method is successfully marked FINAL but then fails when marked OVERRIDE as well, the method by definition does not need to be virtual. R=esprehn@chromium.org TEST=wktry Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149493

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M Source/core/dom/Element.h View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Chris Evans
Split out from FINALizing CL, as discussed earlier.
7 years, 7 months ago (2013-04-30 23:27:13 UTC) #1
esprehn
LGTM.
7 years, 7 months ago (2013-04-30 23:39:46 UTC) #2
jamesr
Why doesn't FINAL imply OVERRIDE?
7 years, 7 months ago (2013-04-30 23:42:07 UTC) #3
esprehn
On 2013/04/30 23:42:07, jamesr wrote: > Why doesn't FINAL imply OVERRIDE? That's a really good ...
7 years, 7 months ago (2013-05-01 00:12:18 UTC) #4
Chris Evans
Committed patchset #1 manually as r149493 (presubmit successful).
7 years, 7 months ago (2013-05-01 00:25:38 UTC) #5
Chris Evans
7 years, 7 months ago (2013-05-01 00:54:34 UTC) #6
Message was sent while issue was closed.
On 2013/05/01 00:12:18, esprehn wrote:
> On 2013/04/30 23:42:07, jamesr wrote:
> > Why doesn't FINAL imply OVERRIDE?
> 
> That's a really good question!

I agree! Perhaps it's compiler-specific, but clang for sure doesn't imply
override when it has final.
(This of course refers to method annotations; override is not a supported
keyword on class-wide annotations.)

Since FINAL and OVERRIDE are macros, I could introduce FINAL_METHOD macro (which
is just "override final" on compilers with support) and do a mass search/replace
if you think there's value?

Powered by Google App Engine
This is Rietveld 408576698