Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1472193003: Double the API call rate threshold for the memory reducer to kick in (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Double the API call rate threshold for the memory reducer to kick in Moving Blink from hidden values to private symbols almost doubled the rate of API calls, as the private symbols API increases the call-depth scope while the hidden values one didn't. I manually checked that this fixes the regression on the long running gmail benchmark but doesn't add new memory reducer GCs on the infinite scrolling benchmark BUG=chromium:561325 R=ulan@chromium.org LOG=n Committed: https://crrev.com/9ec240d00cb8c59a33005accab1151ca3b741638 Cr-Commit-Position: refs/heads/master@{#32279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/memory-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-11-25 14:04:12 UTC) #1
ulan
lgtm
5 years ago (2015-11-25 14:05:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472193003/1
5 years ago (2015-11-25 14:06:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 15:20:09 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-25 15:20:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ec240d00cb8c59a33005accab1151ca3b741638
Cr-Commit-Position: refs/heads/master@{#32279}

Powered by Google App Engine
This is Rietveld 408576698