Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1472183002: add a failing test case to demonstrate a substitution issue (Closed)

Created:
5 years ago by Jennifer Messerly
Modified:
5 years ago
Reviewers:
Leaf, Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add a failing test case to demonstrate a substitution issue R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/12c8e493649f221525f3e5252d1dea7f08f31475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
5 years ago (2015-11-24 21:37:34 UTC) #2
Leaf
lgtm, thanks.
5 years ago (2015-11-24 21:43:16 UTC) #3
Jennifer Messerly
Committed patchset #1 (id:1) manually as 12c8e493649f221525f3e5252d1dea7f08f31475 (presubmit successful).
5 years ago (2015-11-24 21:44:01 UTC) #4
Brian Wilkerson
5 years ago (2015-11-24 21:52:38 UTC) #5
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698