Update pdfium.py to support running pdfium tests with Dr. Memory

Update pdfium.py to support running pdfium tests with Dr. Memory

- add property drmemory for running Dr. Memory
- update _RunTests to run pdfium tests with/without Dr. Memory
- add pdfium.expected/drm_win_xfa.json

R=dpranke@chromium.org
BUG=PDFium:238
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297713

[Dirk Pranke, 2015-11-25 03:58:05]

mostly looks okay, though I'm puzzled by why the win test didn't break?

https://codereview.chromium.org/1472163002/diff/1/scripts/slave/recipes/pdfiu...
File scripts/slave/recipes/pdfium.py (right):

https://codereview.chromium.org/1472163002/diff/1/scripts/slave/recipes/pdfiu...
scripts/slave/recipes/pdfium.py:48: 'pdfium_unittests'))
did you lose the 'is_win' check here?

[zhaoqin1, 2015-11-25 06:17:50]

On 2015/11/25 03:58:05, Dirk Pranke wrote:
> mostly looks okay, though I'm puzzled by why the win test didn't break?
> 
>
https://codereview.chromium.org/1472163002/diff/1/scripts/slave/recipes/pdfiu...
> File scripts/slave/recipes/pdfium.py (right):
> 
>
https://codereview.chromium.org/1472163002/diff/1/scripts/slave/recipes/pdfiu...
> scripts/slave/recipes/pdfium.py:48: 'pdfium_unittests'))
> did you lose the 'is_win' check here?


It must be caused by the mismatch between my Windows/Linux. I usually send CL
from my Linux machine, sometime I forget sync the two.

Tested on Windows: /cygdrive/d/src/webrtc/depot_tools/python.bat
scripts/tools/run_recipe.py pdfium
1. it runs fine for the first Windows config, i.e., master without Dr. Memory
2. it seems that it does not run other Windows configs, I can enforce it by
keeping the only one I want to test and removing the others.
3. it seems that it does not pass the api.properties value, i.e., branch or
drmemory is not passed in:
   in my test:
    cmd: ['python', '-u',
'D:\\src\\Chromium\\buildbots\\depot_tools\\gclient.py', 'sync', '--nohooks',
'--force', '--verbose', '--delete_unversioned_trees', '--output-json',
'c:\\users\\zhaoqin\\appdata\\local\\temp\\tmpjutwsq.json']
   the one on bots:
    cmd: ['python', '-u', 'E:\\b\\depot_tools\\gclient.py', 'sync', '--nohooks',
'--force', '--verbose', '--delete_unversioned_trees', '--revision',
'pdfium@origin/xfa', '--output-json',
'c:\\users\\chrome~2\\appdata\\local\\temp\\tmpdcecew.json']
Do you have any idea why it does not set properties properly?
I have to assume properties 'drmemory' will be pass correctly since I cannot
test it.

[Dirk Pranke, 2015-11-25 21:57:53]

On 2015/11/25 06:17:50, zhaoqin1 wrote:
> On 2015/11/25 03:58:05, Dirk Pranke wrote:
> > mostly looks okay, though I'm puzzled by why the win test didn't break?
> > 
> >
>
https://codereview.chromium.org/1472163002/diff/1/scripts/slave/recipes/pdfiu...
> > File scripts/slave/recipes/pdfium.py (right):
> > 
> >
>
https://codereview.chromium.org/1472163002/diff/1/scripts/slave/recipes/pdfiu...
> > scripts/slave/recipes/pdfium.py:48: 'pdfium_unittests'))
> > did you lose the 'is_win' check here?
> 
> 
> It must be caused by the mismatch between my Windows/Linux. I usually send CL
> from my Linux machine, sometime I forget sync the two.
> 
> Tested on Windows: /cygdrive/d/src/webrtc/depot_tools/python.bat
> scripts/tools/run_recipe.py pdfium
> 1. it runs fine for the first Windows config, i.e., master without Dr. Memory
> 2. it seems that it does not run other Windows configs, I can enforce it by
> keeping the only one I want to test and removing the others.
> 3. it seems that it does not pass the api.properties value, i.e., branch or
> drmemory is not passed in:
>    in my test:
>     cmd: ['python', '-u',
> 'D:\\src\\Chromium\\buildbots\\depot_tools\\gclient.py', 'sync', '--nohooks',
> '--force', '--verbose', '--delete_unversioned_trees', '--output-json',
> 'c:\\users\\zhaoqin\\appdata\\local\\temp\\tmpjutwsq.json']
>    the one on bots:
>     cmd: ['python', '-u', 'E:\\b\\depot_tools\\gclient.py', 'sync',
'--nohooks',
> '--force', '--verbose', '--delete_unversioned_trees', '--revision',
> 'pdfium@origin/xfa', '--output-json',
> 'c:\\users\\chrome~2\\appdata\\local\\temp\\tmpdcecew.json']
> Do you have any idea why it does not set properties properly?
> I have to assume properties 'drmemory' will be pass correctly since I cannot
> test it.

I have no idea offhand. We don't typically run the simulation tests on windows,
so I have no idea what sort of bugs you might be hitting.

Running the tests on linux should cover all of the platforms; you don't need
to run the tests per-platform.

[Dirk Pranke, 2015-11-25 21:58:13]

lgtm, assuming the build presubmit checks pass.

[zhaoqin, 2015-11-25 22:26:39]

The CQ bit was checked by zhaoqin@google.com

[zhaoqin, 2015-11-25 22:26:40]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1472163002/#ps60001
(title: "add tree closing exception")

[commit-bot: I haz the power, 2015-11-25 22:26:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1472163002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1472163002/60001

[commit-bot: I haz the power, 2015-11-25 22:34:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 22:34:05]

Try jobs failed on following builders:
  build_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit...)

[Dirk Pranke, 2015-11-25 22:37:02]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2015-11-25 22:37:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1472163002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1472163002/60001

[zhaoqin, 2015-11-25 22:38:32]

The CQ bit was unchecked by zhaoqin@google.com

[zhaoqin, 2015-11-25 22:43:27]

The CQ bit was checked by zhaoqin@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-25 22:43:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1472163002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1472163002/80001

[commit-bot: I haz the power, 2015-11-25 22:49:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 22:49:25]

Dry run: This issue passed the CQ dry run.

[zhaoqin, 2015-11-25 22:49:56]

The CQ bit was checked by zhaoqin@google.com

[zhaoqin, 2015-11-25 22:49:56]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1472163002/#ps80001
(title: "add missing delimiter")

[commit-bot: I haz the power, 2015-11-25 22:50:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1472163002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1472163002/80001

[commit-bot: I haz the power, 2015-11-25 22:57:46]

Description was changed from

==========
Update pdfium.py to support running pdfium tests with Dr. Memory

- add property drmemory for running Dr. Memory
- update _RunTests to run pdfium tests with/without Dr. Memory
- add pdfium.expected/drm_win_xfa.json

R=dpranke@chromium.org
BUG=PDFium:238
==========

to

==========
Update pdfium.py to support running pdfium tests with Dr. Memory

- add property drmemory for running Dr. Memory
- update _RunTests to run pdfium tests with/without Dr. Memory
- add pdfium.expected/drm_win_xfa.json

R=dpranke@chromium.org
BUG=PDFium:238

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297713
==========

[commit-bot: I haz the power, 2015-11-25 22:57:47]

Committed patchset #5 (id:80001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297713