Refactor DNS A/B experient, and add test of congestion time limits...

chrome/browser/net/dns_master_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <time.h>
 
 #include <algorithm>
 #include <sstream>
 #include <string>
 
@@ skipping 42 matching lines @@
  private:
   DnsMaster* master_;
   const NameList hosts_;
   HelperTimer* timer_;
 };
 
 class DnsMasterTest : public testing::Test {
  public:
   DnsMasterTest()
       : mapper_(new net::RuleBasedHostMapper()),
+        default_max_queueing_delay_(TimeDelta::FromMilliseconds(
+            DnsPrefetcherInit::kMaxQueueingDelayMs)),
         scoped_mapper_(mapper_.get()) {
   }
 
  protected:
   virtual void SetUp() {
 #if defined(OS_WIN)
     net::EnsureWinsockInit();
 #endif
     mapper_->AddRuleWithLatency("www.google.com", "127.0.0.1", 50);
     mapper_->AddRuleWithLatency("gmail.google.com.com", "127.0.0.1", 70);
     mapper_->AddRuleWithLatency("mail.google.com", "127.0.0.1", 44);
     mapper_->AddRuleWithLatency("gmail.com", "127.0.0.1", 63);
   }
 
   void WaitForResolution(DnsMaster* master, const NameList& hosts) {
     HelperTimer* timer = new HelperTimer();
     timer->Start(TimeDelta::FromMilliseconds(100),
                  new WaitForResolutionHelper(master, hosts, timer),
                  &WaitForResolutionHelper::Run);
     MessageLoop::current()->Run();
   }
 
   scoped_refptr<net::RuleBasedHostMapper> mapper_;
 
+  // Shorthand to access TimeDelta of DnsPrefetcherInit::kMaxQueueingDelayMs.
+  // (It would be a static constant... except style rules preclude that :-/ ).
+  const TimeDelta default_max_queueing_delay_;
+
  private:
   MessageLoop loop;
   net::ScopedHostMapper scoped_mapper_;
 };
 
 //------------------------------------------------------------------------------
 // Provide a function to create unique (nonexistant) domains at *every* call.
 //------------------------------------------------------------------------------
 static std::string GetNonexistantDomain() {
   static std::string postfix = ".google.com";
@@ skipping 59 matching lines @@
     if (all_lookups >= 10)
       if (lookups_with_improvement * 100 > all_lookups * 75)
         // Okay, we see the improvement for more than 75% of all lookups.
         return;
   }
   FAIL() << "No substantial improvement in lookup time.";
 }
 
 TEST_F(DnsMasterTest, StartupShutdownTest) {
   scoped_refptr<DnsMaster> testing_master = new DnsMaster(new net::HostResolver,
-      MessageLoop::current(), DnsPrefetcherInit::kMaxConcurrentLookups);
+      MessageLoop::current(), default_max_queueing_delay_,
+      DnsPrefetcherInit::kMaxConcurrentLookups);
   testing_master->Shutdown();
 }
 
 TEST_F(DnsMasterTest, BenefitLookupTest) {
   scoped_refptr<DnsMaster> testing_master = new DnsMaster(new net::HostResolver,
-      MessageLoop::current(), DnsPrefetcherInit::kMaxConcurrentLookups);
+      MessageLoop::current(), default_max_queueing_delay_,
+      DnsPrefetcherInit::kMaxConcurrentLookups);
 
   std::string goog("www.google.com"),
     goog2("gmail.google.com.com"),
     goog3("mail.google.com"),
     goog4("gmail.com");
   DnsHostInfo goog_info, goog2_info, goog3_info, goog4_info;
 
   // Simulate getting similar names from a network observer
   goog_info.SetHostname(goog);
   goog2_info.SetHostname(goog2);
@@ skipping 42 matching lines @@
   EXPECT_FALSE(testing_master->AccruePrefetchBenefits(GURL(), &goog4_info));
 
   testing_master->Shutdown();
 }
 
 TEST_F(DnsMasterTest, ShutdownWhenResolutionIsPendingTest) {
   scoped_refptr<net::WaitingHostMapper> mapper = new net::WaitingHostMapper();
   net::ScopedHostMapper scoped_mapper(mapper.get());
 
   scoped_refptr<DnsMaster> testing_master = new DnsMaster(new net::HostResolver,
-      MessageLoop::current(), DnsPrefetcherInit::kMaxConcurrentLookups);
+      MessageLoop::current(), default_max_queueing_delay_,
+      DnsPrefetcherInit::kMaxConcurrentLookups);
 
   std::string localhost("127.0.0.1");
   NameList names;
   names.insert(names.end(), localhost);
 
   testing_master->ResolveList(names, DnsHostInfo::PAGE_SCAN_MOTIVATED);
 
   MessageLoop::current()->PostDelayedTask(FROM_HERE,
                                           new MessageLoop::QuitTask(), 500);
   MessageLoop::current()->Run();
 
   EXPECT_FALSE(testing_master->WasFound(localhost));
 
   testing_master->Shutdown();
 
   // Clean up after ourselves.
   mapper->Signal();
   MessageLoop::current()->RunAllPending();
 }
 
 TEST_F(DnsMasterTest, SingleLookupTest) {
   scoped_refptr<DnsMaster> testing_master = new DnsMaster(new net::HostResolver,
-      MessageLoop::current(), DnsPrefetcherInit::kMaxConcurrentLookups);
+      MessageLoop::current(), default_max_queueing_delay_,
+      DnsPrefetcherInit::kMaxConcurrentLookups);
 
   std::string goog("www.google.com");
 
   NameList names;
   names.insert(names.end(), goog);
 
   // Try to flood the master with many concurrent requests.
   for (int i = 0; i < 10; i++)
     testing_master->ResolveList(names, DnsHostInfo::PAGE_SCAN_MOTIVATED);
 
   WaitForResolution(testing_master, names);
 
   EXPECT_TRUE(testing_master->WasFound(goog));
 
   MessageLoop::current()->RunAllPending();
 
   EXPECT_GT(testing_master->peak_pending_lookups(), names.size() / 2);
   EXPECT_LE(testing_master->peak_pending_lookups(), names.size());
   EXPECT_LE(testing_master->peak_pending_lookups(),
             DnsPrefetcherInit::kMaxConcurrentLookups);
 
   testing_master->Shutdown();
 }
 
 TEST_F(DnsMasterTest, ConcurrentLookupTest) {
   mapper_->AddSimulatedFailure("*.notfound");
 
   scoped_refptr<DnsMaster> testing_master = new DnsMaster(new net::HostResolver,
-      MessageLoop::current(), DnsPrefetcherInit::kMaxConcurrentLookups);
+      MessageLoop::current(), default_max_queueing_delay_,
+      DnsPrefetcherInit::kMaxConcurrentLookups);
 
   std::string goog("www.google.com"),
     goog2("gmail.google.com.com"),
     goog3("mail.google.com"),
     goog4("gmail.com");
   std::string bad1("bad1.notfound"),
     bad2("bad2.notfound");
 
   NameList names;
   names.insert(names.end(), goog);
@@ skipping 33 matching lines @@
   EXPECT_LE(testing_master->peak_pending_lookups(),
             DnsPrefetcherInit::kMaxConcurrentLookups);
 
   testing_master->Shutdown();
 }
 
 TEST_F(DnsMasterTest, DISABLED_MassiveConcurrentLookupTest) {
   mapper_->AddSimulatedFailure("*.notfound");
 
   scoped_refptr<DnsMaster> testing_master = new DnsMaster(new net::HostResolver,
-      MessageLoop::current(), DnsPrefetcherInit::kMaxConcurrentLookups);
+      MessageLoop::current(), default_max_queueing_delay_,
+      DnsPrefetcherInit::kMaxConcurrentLookups);
 
   NameList names;
   for (int i = 0; i < 100; i++)
     names.push_back("host" + IntToString(i) + ".notfound");
 
   // Try to flood the master with many concurrent requests.
   for (int i = 0; i < 10; i++)
     testing_master->ResolveList(names, DnsHostInfo::PAGE_SCAN_MOTIVATED);
 
   WaitForResolution(testing_master, names);
@@ skipping 83 matching lines @@
     ++i;  // Skip latency value.
   }
   return kLatencyNotFound;
 }
 
 //------------------------------------------------------------------------------
 
 // Make sure nil referral lists really have no entries, and no latency listed.
 TEST_F(DnsMasterTest, ReferrerSerializationNilTest) {
   scoped_refptr<DnsMaster> master = new DnsMaster(new net::HostResolver,
-      MessageLoop::current(), DnsPrefetcherInit::kMaxConcurrentLookups);
+      MessageLoop::current(), default_max_queueing_delay_,
+      DnsPrefetcherInit::kMaxConcurrentLookups);
   ListValue referral_list;
   master->SerializeReferrers(&referral_list);
   EXPECT_EQ(0U, referral_list.GetSize());
   EXPECT_EQ(kLatencyNotFound, GetLatencyFromSerialization("a.com", "b.com",
                                                           referral_list));
 
   master->Shutdown();
 }
 
 // Make sure that when a serialization list includes a value, that it can be
 // deserialized into the database, and can be extracted back out via
 // serialization without being changed.
 TEST_F(DnsMasterTest, ReferrerSerializationSingleReferrerTest) {
   scoped_refptr<DnsMaster> master = new DnsMaster(new net::HostResolver,
-      MessageLoop::current(), DnsPrefetcherInit::kMaxConcurrentLookups);
+      MessageLoop::current(), default_max_queueing_delay_,
+      DnsPrefetcherInit::kMaxConcurrentLookups);
   std::string motivation_hostname = "www.google.com";
   std::string subresource_hostname = "icons.google.com";
   const int kLatency = 3;
   ListValue referral_list;
 
   AddToSerializedList(motivation_hostname, subresource_hostname, kLatency,
                       &referral_list);
 
   master->DeserializeReferrers(referral_list);
 
   ListValue recovered_referral_list;
   master->SerializeReferrers(&recovered_referral_list);
   EXPECT_EQ(1U, recovered_referral_list.GetSize());
   EXPECT_EQ(kLatency, GetLatencyFromSerialization(motivation_hostname,
                                                   subresource_hostname,
                                                   recovered_referral_list));
 
   master->Shutdown();
 }
 
 // Make sure the Trim() functionality works as expected.
 TEST_F(DnsMasterTest, ReferrerSerializationTrimTest) {
   scoped_refptr<DnsMaster> master = new DnsMaster(new net::HostResolver,
-      MessageLoop::current(), DnsPrefetcherInit::kMaxConcurrentLookups);
+      MessageLoop::current(), default_max_queueing_delay_,
+      DnsPrefetcherInit::kMaxConcurrentLookups);
   std::string motivation_hostname = "www.google.com";
   std::string icon_subresource_hostname = "icons.google.com";
   std::string img_subresource_hostname = "img.google.com";
   ListValue referral_list;
 
   AddToSerializedList(motivation_hostname, icon_subresource_hostname, 10,
                       &referral_list);
   AddToSerializedList(motivation_hostname, img_subresource_hostname, 3,
                       &referral_list);
 
@@ skipping 113 matching lines @@
   EXPECT_EQ(queue.Pop(), "startup");
   EXPECT_EQ(queue.Pop(), "omni");
 
   EXPECT_TRUE(queue.IsEmpty());
 }
 
 
 
 
 }  // namespace chrome_browser_net