Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1472143003: PasswordCredential should remove entries named idName or passwordName in additionalData (Closed)

Created:
5 years ago by tyoshino (SeeGerritForStatus)
Modified:
5 years ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In body extraction process, PasswordCredential should remove entries named idName or passwordName in additionalData. This CL also fix a minor bug in passwordcredential-fetch.html BUG=556431 R=mkwst Committed: https://crrev.com/a56acac88b2888494c899d02f801af4db327b47d Cr-Commit-Position: refs/heads/master@{#361874}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch.html View 3 chunks +54 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp View 1 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
tyoshino (SeeGerritForStatus)
5 years ago (2015-11-25 14:43:32 UTC) #4
Mike West
Thank you. LGTM!
5 years ago (2015-11-25 15:13:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472143003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472143003/20001
5 years ago (2015-11-26 10:52:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-26 12:56:21 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-26 12:57:19 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a56acac88b2888494c899d02f801af4db327b47d
Cr-Commit-Position: refs/heads/master@{#361874}

Powered by Google App Engine
This is Rietveld 408576698