Issue 147213004: Revert of Convert remaining RenderSVG* nodes to RenderObject::isChildAllowed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147213004: Revert of Convert remaining RenderSVG* nodes to RenderObject::isChildAllowed (Closed)

Created:
6 years, 10 months ago by fs

Modified:
6 years, 10 months ago

Reviewers:
pdr., schenney

CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr, Stephen Chennney, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert of Convert remaining RenderSVG* nodes to RenderObject::isChildAllowed Revert r165851 and r166238 because of performance regressions (issue 339470). BUG=339470 TBR=pdr,schenney Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166392

Patch Set 1 #

Patch Set 2 : Rebase; Include r166238. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -58 lines)			Patch
M	Source/core/rendering/svg/RenderSVGInline.cpp	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGModelObject.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGModelObject.cpp	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGRoot.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGRoot.cpp	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGTransformableContainer.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGTransformableContainer.cpp	View		1 chunk	+0 lines, -31 lines	0 comments	Download
M	Source/core/svg/SVGAElement.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGAElement.cpp	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGElement.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGElement.cpp	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGSwitchElement.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGSwitchElement.cpp	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/147213004/30001

6 years, 10 months ago (2014-02-04 09:47:43 UTC) #3

Message was sent while issue was closed.

Change committed as 166392

Expand Messages | Collapse Messages