Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 147213004: Revert of Convert remaining RenderSVG* nodes to RenderObject::isChildAllowed (Closed)

Created:
6 years, 10 months ago by fs
Modified:
6 years, 10 months ago
Reviewers:
pdr., schenney
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr, Stephen Chennney, rwlbuis
Visibility:
Public.

Description

Revert of Convert remaining RenderSVG* nodes to RenderObject::isChildAllowed Revert r165851 and r166238 because of performance regressions (issue 339470). BUG=339470 TBR=pdr,schenney Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166392

Patch Set 1 #

Patch Set 2 : Rebase; Include r166238. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -58 lines) Patch
M Source/core/rendering/svg/RenderSVGInline.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGTransformableContainer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGTransformableContainer.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
M Source/core/svg/SVGAElement.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAElement.cpp View 1 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/svg/SVGSwitchElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSwitchElement.cpp View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fs
6 years, 10 months ago (2014-02-04 09:45:52 UTC) #1
fs
The CQ bit was checked by fs@opera.com
6 years, 10 months ago (2014-02-04 09:45:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/147213004/30001
6 years, 10 months ago (2014-02-04 09:47:43 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 12:21:28 UTC) #4
Message was sent while issue was closed.
Change committed as 166392

Powered by Google App Engine
This is Rietveld 408576698