src/codec/SkCodec_libgif.cpp - Issue 1472123002: Make SkCodec support peek() and read()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkCodec_libgif.cpp

Issue 1472123002: Make SkCodec support peek() and read() (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add comments, test, and accessor for needed buffer bytes Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkCodec_libgif.cpp

diff --git a/src/codec/SkCodec_libgif.cpp b/src/codec/SkCodec_libgif.cpp

index 8021af95a2e050f1b2df82985d9f467203e108b2..bb5e1ccb70d327ae6ff23c8d713f1b23d022fcb0 100644

--- a/src/codec/SkCodec_libgif.cpp

+++ b/src/codec/SkCodec_libgif.cpp

@@ -16,9 +16,8 @@

* Checks the start of the stream to see if the image is a gif

-bool SkGifCodec::IsGif(SkStream* stream) {

- char buf[GIF_STAMP_LEN];

- if (stream->read(buf, GIF_STAMP_LEN) == GIF_STAMP_LEN) {

+bool SkGifCodec::IsGif(const char* buf, size_t bytesRead) {

+ if (bytesRead >= GIF_STAMP_LEN) {

if (memcmp(GIF_STAMP, buf, GIF_STAMP_LEN) == 0 ||

memcmp(GIF87_STAMP, buf, GIF_STAMP_LEN) == 0 ||

memcmp(GIF89_STAMP, buf, GIF_STAMP_LEN) == 0)