src/x64/lithium-x64.cc - Issue 14721009: Track computed literal properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-x64.cc

Issue 14721009: Track computed literal properties. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-x64.cc

diff --git a/src/x64/lithium-x64.cc b/src/x64/lithium-x64.cc

index 0945172962b9cceeaf7a1d522b97c20b1d40d222..7f6a297f4592aa3f92c739df724e802136c1188e 100644

--- a/src/x64/lithium-x64.cc

+++ b/src/x64/lithium-x64.cc

@@ -2287,10 +2287,11 @@ LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) {

needs_write_barrier_for_map) ? TempRegister() : NULL;

LStoreNamedField* result = new(zone()) LStoreNamedField(obj, val, temp);

- if ((FLAG_track_fields && instr->field_representation().IsSmi()) ||

- (FLAG_track_heap_object_fields &&

- instr->field_representation().IsHeapObject())) {

- return AssignEnvironment(result);

+ if (FLAG_track_heap_object_fields &&

+ instr->field_representation().IsHeapObject()) {

+ if (!instr->value()->type().IsHeapObject()) {

+ return AssignEnvironment(result);

+ }

}

return result;

}