Chromium Code Reviews| Index: src/arm/lithium-arm.cc |
| diff --git a/src/arm/lithium-arm.cc b/src/arm/lithium-arm.cc |
| index 1c64d8e61ef97c39781ea1afb1be93f48ee254c3..7656d365e8b374f43bb07298292e4f39bae6c038 100644 |
| --- a/src/arm/lithium-arm.cc |
| +++ b/src/arm/lithium-arm.cc |
| @@ -2347,10 +2347,15 @@ LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) { |
| LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL; |
| LStoreNamedField* result = new(zone()) LStoreNamedField(obj, val, temp); |
| - if ((FLAG_track_fields && instr->field_representation().IsSmi()) || |
| - (FLAG_track_heap_object_fields && |
| - instr->field_representation().IsHeapObject())) { |
| - return AssignEnvironment(result); |
| + if (FLAG_track_fields && instr->field_representation().IsSmi()) { |
| + if (!instr->value()->range()->IsInSmiRange()) { |
|
danno
2013/06/06 07:54:19
What about also checking !instr->value()->type().I
Toon Verwaest
2013/06/06 10:31:41
This is an obsolete requirement. Nowadays we requi
|
| + return AssignEnvironment(result); |
| + } |
| + } else if (FLAG_track_heap_object_fields && |
| + instr->field_representation().IsHeapObject()) { |
| + if (!instr->value()->type().IsHeapObject()) { |
| + return AssignEnvironment(result); |
| + } |
| } |
| return result; |
| } |