Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: src/objects-debug.cc

Issue 14721009: Track computed literal properties. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 if (HasFastProperties()) { 305 if (HasFastProperties()) {
306 CHECK_EQ(map()->unused_property_fields(), 306 CHECK_EQ(map()->unused_property_fields(),
307 (map()->inobject_properties() + properties()->length() - 307 (map()->inobject_properties() + properties()->length() -
308 map()->NextFreePropertyIndex())); 308 map()->NextFreePropertyIndex()));
309 DescriptorArray* descriptors = map()->instance_descriptors(); 309 DescriptorArray* descriptors = map()->instance_descriptors();
310 for (int i = 0; i < map()->NumberOfOwnDescriptors(); i++) { 310 for (int i = 0; i < map()->NumberOfOwnDescriptors(); i++) {
311 if (descriptors->GetDetails(i).type() == FIELD) { 311 if (descriptors->GetDetails(i).type() == FIELD) {
312 Representation r = descriptors->GetDetails(i).representation(); 312 Representation r = descriptors->GetDetails(i).representation();
313 int field = descriptors->GetFieldIndex(i); 313 int field = descriptors->GetFieldIndex(i);
314 Object* value = RawFastPropertyAt(field); 314 Object* value = RawFastPropertyAt(field);
315 if (r.IsDouble()) ASSERT(value->IsHeapNumber());
316 // Ignore values set to undefined. Undefined could be the placeholder
317 // for fields that did not yet have a representation.
318 if (value->IsUndefined()) continue;
315 if (r.IsSmi()) ASSERT(value->IsSmi()); 319 if (r.IsSmi()) ASSERT(value->IsSmi());
316 if (r.IsDouble()) ASSERT(value->IsHeapNumber());
317 if (r.IsHeapObject()) ASSERT(value->IsHeapObject()); 320 if (r.IsHeapObject()) ASSERT(value->IsHeapObject());
318 } 321 }
319 } 322 }
320 } 323 }
321 CHECK_EQ((map()->has_fast_smi_or_object_elements() || 324 CHECK_EQ((map()->has_fast_smi_or_object_elements() ||
322 (elements() == GetHeap()->empty_fixed_array())), 325 (elements() == GetHeap()->empty_fixed_array())),
323 (elements()->map() == GetHeap()->fixed_array_map() || 326 (elements()->map() == GetHeap()->fixed_array_map() ||
324 elements()->map() == GetHeap()->fixed_cow_array_map())); 327 elements()->map() == GetHeap()->fixed_cow_array_map()));
325 CHECK(map()->has_fast_object_elements() == HasFastObjectElements()); 328 CHECK(map()->has_fast_object_elements() == HasFastObjectElements());
326 } 329 }
(...skipping 792 matching lines...) Expand 10 before | Expand all | Expand 10 after
1119 for (int i = 0; i < number_of_transitions(); ++i) { 1122 for (int i = 0; i < number_of_transitions(); ++i) {
1120 if (!CheckOneBackPointer(current_map, GetTarget(i))) return false; 1123 if (!CheckOneBackPointer(current_map, GetTarget(i))) return false;
1121 } 1124 }
1122 return true; 1125 return true;
1123 } 1126 }
1124 1127
1125 1128
1126 #endif // DEBUG 1129 #endif // DEBUG
1127 1130
1128 } } // namespace v8::internal 1131 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698