Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 14721009: Track computed literal properties. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2453 matching lines...) Expand 10 before | Expand all | Expand 10 after
2464 // We only need a scratch register if we have a write barrier or we 2464 // We only need a scratch register if we have a write barrier or we
2465 // have a store into the properties array (not in-object-property). 2465 // have a store into the properties array (not in-object-property).
2466 LOperand* temp = (!is_in_object || needs_write_barrier || 2466 LOperand* temp = (!is_in_object || needs_write_barrier ||
2467 needs_write_barrier_for_map) ? TempRegister() : NULL; 2467 needs_write_barrier_for_map) ? TempRegister() : NULL;
2468 2468
2469 // We need a temporary register for write barrier of the map field. 2469 // We need a temporary register for write barrier of the map field.
2470 LOperand* temp_map = needs_write_barrier_for_map ? TempRegister() : NULL; 2470 LOperand* temp_map = needs_write_barrier_for_map ? TempRegister() : NULL;
2471 2471
2472 LStoreNamedField* result = 2472 LStoreNamedField* result =
2473 new(zone()) LStoreNamedField(obj, val, temp, temp_map); 2473 new(zone()) LStoreNamedField(obj, val, temp, temp_map);
2474 if ((FLAG_track_fields && instr->field_representation().IsSmi()) || 2474 if (FLAG_track_heap_object_fields &&
2475 (FLAG_track_heap_object_fields && 2475 instr->field_representation().IsHeapObject()) {
2476 instr->field_representation().IsHeapObject())) { 2476 if (!instr->value()->type().IsHeapObject()) {
danno 2013/06/06 13:07:32 And this one, too.
Toon Verwaest 2013/06/06 13:22:26 Done.
2477 return AssignEnvironment(result); 2477 return AssignEnvironment(result);
2478 }
2478 } 2479 }
2479 return result; 2480 return result;
2480 } 2481 }
2481 2482
2482 2483
2483 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) { 2484 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) {
2484 LOperand* context = UseFixed(instr->context(), esi); 2485 LOperand* context = UseFixed(instr->context(), esi);
2485 LOperand* object = UseFixed(instr->object(), edx); 2486 LOperand* object = UseFixed(instr->object(), edx);
2486 LOperand* value = UseFixed(instr->value(), eax); 2487 LOperand* value = UseFixed(instr->value(), eax);
2487 2488
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
2773 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2774 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2774 LOperand* object = UseRegister(instr->object()); 2775 LOperand* object = UseRegister(instr->object());
2775 LOperand* index = UseTempRegister(instr->index()); 2776 LOperand* index = UseTempRegister(instr->index());
2776 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2777 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2777 } 2778 }
2778 2779
2779 2780
2780 } } // namespace v8::internal 2781 } } // namespace v8::internal
2781 2782
2782 #endif // V8_TARGET_ARCH_IA32 2783 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698