Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 14721009: Track computed literal properties. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | src/ia32/lithium-ia32.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2329 matching lines...) Expand 10 before | Expand all | Expand 10 after
2340 instr->field_representation().IsDouble()) { 2340 instr->field_representation().IsDouble()) {
2341 val = UseRegisterAtStart(instr->value()); 2341 val = UseRegisterAtStart(instr->value());
2342 } else { 2342 } else {
2343 val = UseRegister(instr->value()); 2343 val = UseRegister(instr->value());
2344 } 2344 }
2345 2345
2346 // We need a temporary register for write barrier of the map field. 2346 // We need a temporary register for write barrier of the map field.
2347 LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL; 2347 LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL;
2348 2348
2349 LStoreNamedField* result = new(zone()) LStoreNamedField(obj, val, temp); 2349 LStoreNamedField* result = new(zone()) LStoreNamedField(obj, val, temp);
2350 if ((FLAG_track_fields && instr->field_representation().IsSmi()) || 2350 if (FLAG_track_heap_object_fields &&
2351 (FLAG_track_heap_object_fields && 2351 instr->field_representation().IsHeapObject()) {
2352 instr->field_representation().IsHeapObject())) { 2352 if (!instr->value()->type().IsHeapObject()) {
2353 return AssignEnvironment(result); 2353 return AssignEnvironment(result);
2354 }
danno 2013/06/06 13:07:32 Please split into another CL
Toon Verwaest 2013/06/06 13:22:26 Done.
2354 } 2355 }
2355 return result; 2356 return result;
2356 } 2357 }
2357 2358
2358 2359
2359 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) { 2360 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) {
2360 LOperand* obj = UseFixed(instr->object(), r1); 2361 LOperand* obj = UseFixed(instr->object(), r1);
2361 LOperand* val = UseFixed(instr->value(), r0); 2362 LOperand* val = UseFixed(instr->value(), r0);
2362 2363
2363 LInstruction* result = new(zone()) LStoreNamedGeneric(obj, val); 2364 LInstruction* result = new(zone()) LStoreNamedGeneric(obj, val);
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
2624 2625
2625 2626
2626 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2627 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2627 LOperand* object = UseRegister(instr->object()); 2628 LOperand* object = UseRegister(instr->object());
2628 LOperand* index = UseRegister(instr->index()); 2629 LOperand* index = UseRegister(instr->index());
2629 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2630 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2630 } 2631 }
2631 2632
2632 2633
2633 } } // namespace v8::internal 2634 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | src/ia32/lithium-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698