mustash: enable GPU Compositing in renderer

content/browser/renderer_host/render_widget_host_view_mus.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_mus.h"
 
+#include "base/debug/stack_trace.h"
+
 #include "components/mus/public/cpp/window.h"
 #include "components/mus/public/cpp/window_tree_connection.h"
 #include "content/browser/mojo/mojo_shell_client_host.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/common/render_widget_window_tree_client_factory.mojom.h"
 #include "content/public/common/mojo_shell_connection.h"
 #include "mojo/application/public/cpp/application_impl.h"
 
 namespace blink {
 struct WebScreenInfo;
 }
 
 namespace content {
 
+void DoNothing(bool result) {
+  fprintf(stderr, "EEE %s %d\n", __func__, __LINE__);
+}
+
 RenderWidgetHostViewMus::RenderWidgetHostViewMus(
     mus::Window* parent_window,
     RenderWidgetHostImpl* host,
     base::WeakPtr<RenderWidgetHostViewBase> platform_view)
     : host_(host), platform_view_(platform_view) {
+  // base::debug::StackTrace().Print();
+  //
   DCHECK(parent_window);
   mus::Window* window = parent_window->connection()->NewWindow();
   window->SetVisible(true);
   window->SetBounds(gfx::Rect(300, 300));
   parent_window->AddChild(window);
   window_.reset(new mus::ScopedWindowPtr(window));
   host_->SetView(this);
 
   // Connect to the renderer, pass it a WindowTreeClient interface request
   // and embed that client inside our mus window.
   std::string url = GetMojoApplicationInstanceURL(host_->GetProcess());
   mojom::RenderWidgetWindowTreeClientFactoryPtr factory;
   MojoShellConnection::Get()->GetApplication()->ConnectToService(url, &factory);
 
   mus::mojom::WindowTreeClientPtr window_tree_client;
   factory->CreateWindowTreeClientForRenderWidget(
-      host_->GetRoutingID(), mojo::GetProxy(&window_tree_client));
+      host_->GetRoutingID(), mojo::GetProxy(&window_tree_client),
+      DoNothing);

[Peng, 2015/11/26 22:13:04]

Looks like in the browser process, this function is called before creating the
RenderView. But in the renderer process, the RenderWidgetMusConnection is
created after RenderView.

I tried using factory.WaitForIncomingResponse() to make sure the RWMusConnection
is created first, but factory.WaitForIncomingResponse() never returned.


Hi Fady, do you know why?


BTW, Stacks create RenderView vs RWHVMus

#0 0x7efe12371f7e base::debug::StackTrace::StackTrace()
#1 0x7efe0cb0d021 content::RenderViewHostImpl::CreateRenderView()
#2 0x7efe0cd99696 content::WebContentsImpl::CreateRenderViewForRenderManager()
#3 0x7efe0c6d39be content::RenderFrameHostManager::InitRenderView()
#4 0x7efe0c6dabfa content::RenderFrameHostManager::CreateRenderFrame()
#5 0x7efe0c6da1bf
content::RenderFrameHostManager::CreatePendingRenderFrameHost()
#6 0x7efe0c6d2b16 content::RenderFrameHostManager::UpdateStateForNavigate()
#7 0x7efe0c6d2020 content::RenderFrameHostManager::Navigate()
#8 0x7efe0c6aa57c content::NavigatorImpl::NavigateToEntry()
#9 0x7efe0c6ab2ac content::NavigatorImpl::NavigateToPendingEntry()
#10 0x7efe0c68d6ea
content::NavigationControllerImpl::NavigateToPendingEntryInternal()
#11 0x7efe0c68618c content::NavigationControllerImpl::NavigateToPendingEntry()
#12 0x7efe0c686719 content::NavigationControllerImpl::LoadEntry()
#13 0x7efe0c68879a content::NavigationControllerImpl::LoadURLWithParams()
#14 0x7efe14f65fe9 (anonymous namespace)::LoadURLInContents()
#15 0x7efe14f64d83 chrome::Navigate()
#16 0x7efe14f6b4be chrome::AddTabAt()
#17 0x7efe14f67746 chrome::BrowserTabStripModelDelegate::AddTabAt()
#18 0x7efe1530e81c BrowserTabStripController::CreateNewTab()

======================

#0 0x7f7ce10d9f7e base::debug::StackTrace::StackTrace()
#1 0x7f7cdbc1b43a content::RenderWidgetHostViewMus::RenderWidgetHostViewMus()
#2 0x7f7cdbc1d692 content::WebContentsViewMus::CreateViewForWidget()
#3 0x7f7cdbb01432
content::WebContentsImpl::CreateRenderWidgetHostViewForRenderManager()
#4 0x7f7cdbb015c8 content::WebContentsImpl::CreateRenderViewForRenderManager()
#5 0x7f7cdb43b9be content::RenderFrameHostManager::InitRenderView()
#6 0x7f7cdb442bfa content::RenderFrameHostManager::CreateRenderFrame()
#7 0x7f7cdb4421bf
content::RenderFrameHostManager::CreatePendingRenderFrameHost()
#8 0x7f7cdb43ab16 content::RenderFrameHostManager::UpdateStateForNavigate()
#9 0x7f7cdb43a020 content::RenderFrameHostManager::Navigate()
#10 0x7f7cdb41257c content::NavigatorImpl::NavigateToEntry()
#11 0x7f7cdb4132ac content::NavigatorImpl::NavigateToPendingEntry()
#12 0x7f7cdb3f56ea
content::NavigationControllerImpl::NavigateToPendingEntryInternal()
#13 0x7f7cdb3ee18c content::NavigationControllerImpl::NavigateToPendingEntry()
#14 0x7f7cdb3ee719 content::NavigationControllerImpl::LoadEntry()
#15 0x7f7cdb3f079a content::NavigationControllerImpl::LoadURLWithParams()
#16 0x7f7ce3ccdfe9 (anonymous namespace)::LoadURLInContents()
#17 0x7f7ce3cccd83 chrome::Navigate()
#18 0x7f7ce3cd34be chrome::AddTabAt()
#19 0x7f7ce3ccf746 chrome::BrowserTabStripModelDelegate::AddTabAt()
#20 0x7f7ce407681c BrowserTabStripController::CreateNewTab()

[Fady Samuel, 2015/11/27 00:26:21]

Mojo IPCs and Chrome IPCs can be issued out of order because they use different
queues. +ben@, jam@ for thoughts. We could try my alternative solution here in
the meantime: https://codereview.chromium.org/1461243002/

+  fprintf(stderr, "EEE %s %d\n", __func__, __LINE__);
+  factory.WaitForIncomingResponse();

[Peng, 2015/11/27 15:08:03]

I think WaitForImcomingResponse() should block current thread until renderer
finishes the work, but this function doesn't return for ever, seems deadlock
happens inside it (Or I don't use it correctly).

Fady, any idea about it?

+  fprintf(stderr, "EEE %s %d\n", __func__, __LINE__);
   window_->window()->Embed(window_tree_client.Pass());
 }
 
 RenderWidgetHostViewMus::~RenderWidgetHostViewMus() {}
 
 void RenderWidgetHostViewMus::Show() {
   // TODO(fsamuel): Update visibility in Mus.
   // There is some interstitial complexity that we'll need to figure out here.
   host_->WasShown(ui::LatencyInfo());
 }
@@ skipping 242 matching lines @@
 void RenderWidgetHostViewMus::SetParentNativeViewAccessible(
     gfx::NativeViewAccessible accessible_parent) {}
 
 gfx::NativeViewId RenderWidgetHostViewMus::GetParentForWindowlessPlugin()
     const {
   return gfx::NativeViewId();
 }
 #endif
 
 }  // namespace content