Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1472053003: jni: Pass method parameters as JavaParamRef in remoting. (Closed)

Created:
5 years ago by Torne
Modified:
5 years ago
Reviewers:
Sergey Ulanov, Lambros, solb
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

jni: Pass method parameters as JavaParamRef in remoting. Pass all object parameters to JNI methods in JavaParamRef<> wrappers. This matches previous changes made to do this for JNI non-method functions. BUG=519562 R=solb@chromium.org Committed: https://crrev.com/7c86f69473845dea973d4e231d93ca602783e9f3 Cr-Commit-Position: refs/heads/master@{#363000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M remoting/client/jni/jni_client.h View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/client/jni/jni_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Torne
5 years ago (2015-11-25 14:18:30 UTC) #1
Torne
Ping?
5 years ago (2015-12-03 12:56:16 UTC) #4
Sergey Ulanov
lgtm
5 years ago (2015-12-03 16:53:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472053003/1
5 years ago (2015-12-03 17:06:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 17:19:56 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-03 17:20:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c86f69473845dea973d4e231d93ca602783e9f3
Cr-Commit-Position: refs/heads/master@{#363000}

Powered by Google App Engine
This is Rietveld 408576698