Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1472023003: Remove COMPILE_ASSERT. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
5 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, vmpstr+watch_chromium.org, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove COMPILE_ASSERT. BUG=442514 Committed: https://crrev.com/7c021364e9a9455a28a5e213dbd0a098c48a4189 Cr-Commit-Position: refs/heads/master@{#361602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M base/macros.h View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Avi (use Gerrit)
5 years ago (2015-11-24 16:35:16 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472023003/1
5 years ago (2015-11-24 16:35:50 UTC) #4
Mark Mentovai
LGTM
5 years ago (2015-11-24 16:45:26 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/162037) chromeos_amd64-generic_chromium_compile_only_ng on ...
5 years ago (2015-11-24 16:50:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472023003/1
5 years ago (2015-11-25 03:41:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 07:43:00 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-25 07:43:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c021364e9a9455a28a5e213dbd0a098c48a4189
Cr-Commit-Position: refs/heads/master@{#361602}

Powered by Google App Engine
This is Rietveld 408576698