third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 1471993002: Resume cursor blinking on closing context menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 1471993002: Resume cursor blinking on closing context menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: robusted onContextMenuClosed() and fixed nits Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index 6cd7e9b1da251a7e73f047d45a8cf1fa445099b2..763441d941d2b0a60d9b1ae49c97c1281aea381f 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -3761,6 +3761,13 @@ void WebViewImpl::showContextMenu()

}

+void WebViewImpl::didCloseContextMenu()

+ LocalFrame* frame = m_page->focusController().focusedFrame();

+ if (frame)

+ frame->selection().setCaretBlinkingSuspended(false);

void WebViewImpl::extractSmartClipData(WebRect rectInViewport, WebString& clipText, WebString& clipHtml, WebRect& clipRectInViewport)

{

LocalFrame* localFrame = toLocalFrame(focusedCoreFrame());