Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 1471993002: Resume cursor blinking on closing context menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added comment in test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index de62b51d0efcdc9cc837c42d7f750371246342eb..ac1c331ce5c43dbf0d2ac1b87746fd150a73e65a 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -2566,6 +2566,9 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen
// showing of the paste popup. See http://crbug.com/150151.
if (showPastePopup(x, y)) {
mContainerView.performHapticFeedback(HapticFeedbackConstants.LONG_PRESS);
+ } else {
+ // Resumes cursor blinking even when there is nothing to paste.
+ if (mWebContents != null) mWebContents.onContextMenuClosed();
Ted C 2015/11/30 21:30:49 What is causing the cursor to pause blinking? Do
Changwan Ryu 2015/12/01 05:54:01 We handle long press gesture and send context menu
}
}
@@ -2594,6 +2597,11 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen
mWebContents.paste();
dismissTextHandles();
}
+
+ @Override
+ public void onDismiss() {
+ if (mWebContents != null) mWebContents.onContextMenuClosed();
+ }
};
if (supportsFloatingActionMode()) {
mPastePopupMenu = new FloatingPastePopupMenu(getContainerView(), delegate);

Powered by Google App Engine
This is Rietveld 408576698