Resume cursor blinking on closing context menu

chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
@@ skipping 110 matching lines @@
 import org.chromium.chrome.browser.toolbar.ToolbarManager;
 import org.chromium.chrome.browser.util.ColorUtils;
 import org.chromium.chrome.browser.util.FeatureUtilities;
 import org.chromium.chrome.browser.webapps.AddToHomescreenDialog;
 import org.chromium.chrome.browser.widget.ControlContainer;
 import org.chromium.content.browser.ContentVideoView;
 import org.chromium.content.browser.ContentViewCore;
 import org.chromium.content.common.ContentSwitches;
 import org.chromium.content_public.browser.ContentBitmapCallback;
 import org.chromium.content_public.browser.LoadUrlParams;
+import org.chromium.content_public.browser.WebContents;
 import org.chromium.content_public.browser.readback_types.ReadbackResponse;
 import org.chromium.policy.CombinedPolicyProvider.PolicyChangeListener;
 import org.chromium.printing.PrintManagerDelegateImpl;
 import org.chromium.printing.PrintingController;
 import org.chromium.ui.base.ActivityWindowAndroid;
 import org.chromium.ui.base.PageTransition;
 import org.chromium.ui.base.WindowAndroid;
 
 import java.util.ArrayList;
 import java.util.List;
@@ skipping 1435 matching lines @@
         if (mSetWindowHWA) {
             mSetWindowHWA = false;
             getWindow().setWindowManager(
                     getWindow().getWindowManager(),
                     getWindow().getAttributes().token,
                     getComponentName().flattenToString(),
                     true /* hardwareAccelerated */);
         }
     }
 
+    @Override
+    public void onContextMenuClosed(Menu menu) {

[no sievers, 2015/11/30 21:25:00]

I can't find where this is overriden from.

[Ted C, 2015/11/30 21:30:49]

Hmm...it is sad that we have to add this at this high of a level, but you can't
add a dismiss listener on the Menu during construction, so I think this will
have to do.

Alternatively, you could listen for a combination of window focus/window
visibility at the view level and gather the same amount of information.  I would
assume you'd lose focus when showing the context menu and either gain it back or
lose visibility entirely depending on the user action.

[Changwan Ryu, 2015/12/01 05:54:01]

This overrides Activity#onContextMenuClosed. Added javadoc.

[Changwan Ryu, 2015/12/01 05:54:01]

Hmm.. I considered it, but if context menu opens yet another view, then
depending on the timing the original view may not get window focus or visibility
at the right timing (because it was already lost when context menu pops up), and
the callback will only be called when the user comes back to the original view.
Then the timing of callback may be a bit off, although I cannot think of any
disastrous scenario out of it, but I'm afraid that it might introduce
inconsistency of behavior.

+        final Tab currentTab = getActivityTab();
+        if (currentTab == null) return;
+        WebContents webContents = currentTab.getWebContents();
+        if (webContents == null) return;
+        webContents.onContextMenuClosed();

[Ted C, 2015/11/30 21:30:49]

What happens if the web contents was not the thing that triggered the context
menu?  Could we be incorrectly causing the cursor to blink if something else
triggered one (or does it track whether it was in fact showing a context menu)?

Also, WebView does not have a ChromeActivity, so if you need this to be called
then this will not work like this.

[Changwan Ryu, 2015/12/01 05:54:01]

Good point! I've added WebContents#onContextMenuOpened() to prevent this case.
Since there can be only one context menu at a time, we won't get context menu
callbacks from other places.
AwWebContentsViewDelegate does not trigger ContextMenuHelper, so we won't have
this problem.

+    }
+
     private void enableHardwareAcceleration() {
         // HW acceleration is disabled in the manifest. Enable it only on high-end devices.
         if (!SysUtils.isLowEndDevice()) {
             getWindow().addFlags(WindowManager.LayoutParams.FLAG_HARDWARE_ACCELERATED);
 
             // When HW acceleration is enabled manually for an activity, child windows (e.g.
             // dialogs) don't inherit HW acceleration state. However, when HW acceleration is
             // enabled in the manifest, child windows do inherit HW acceleration state. That
             // looks like a bug, so I filed b/23036374
             //
@@ skipping 10 matching lines @@
     public static int getThemeId() {
         boolean useLowEndTheme =
                 SysUtils.isLowEndDevice() && Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP;
         return (useLowEndTheme ? R.style.MainTheme_LowEnd : R.style.MainTheme);
     }
 
     private void setLowEndTheme() {
         if (getThemeId() == R.style.MainTheme_LowEnd) setTheme(R.style.MainTheme_LowEnd);
     }
 }