Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1471973004: Fix some path processing to work better on Windows. (Closed)

Created:
5 years ago by Michael Moss
Modified:
5 years ago
Reviewers:
Dirk Pranke, hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, Geoff Lang
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix some path processing to work better on Windows. R=hinoka@chromium.org BUG=555036 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297698

Patch Set 1 #

Patch Set 2 : lint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M checkout.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M cit.py View 1 chunk +1 line, -1 line 0 comments Download
M gcl.py View 1 chunk +3 lines, -9 lines 0 comments Download
M gerrit_util.py View 1 chunk +1 line, -1 line 0 comments Download
M repo View 1 chunk +1 line, -1 line 0 comments Download
M scm.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael Moss
5 years ago (2015-11-24 19:47:56 UTC) #1
Dirk Pranke
lgtm
5 years ago (2015-11-24 21:38:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471973004/1
5 years ago (2015-11-24 21:45:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/267)
5 years ago (2015-11-24 22:50:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471973004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471973004/20001
5 years ago (2015-11-24 23:25:21 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-25 01:04:03 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297698

Powered by Google App Engine
This is Rietveld 408576698