Count usage of #svgView(...) and plain SVG <view> targets

third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Rob Buis <buis@kde.org>
  * Copyright (C) 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2014 Google, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 683 matching lines @@
             markForLayoutAndParentResourceInvalidation(layoutObject);
         return;
     }
 
     if (fragmentIdentifier.startsWith("svgView(")) {
         if (!view)
             view = currentView(); // Create the SVGViewSpec.
 
         view->inheritViewAttributesFromElement(this);
 
-        if (view->parseViewSpec(fragmentIdentifier))
+        if (view->parseViewSpec(fragmentIdentifier)) {
+            UseCounter::count(document(), UseCounter::SVGSVGElementFragmentSVGView);
             m_useCurrentView = true;
-        else
+        } else {
             view->reset();
+        }
 
         if (layoutObject && (hadUseCurrentView || m_useCurrentView))
             markForLayoutAndParentResourceInvalidation(layoutObject);
         return;
     }
 
+    UseCounter::count(document(), UseCounter::SVGSVGElementFragment);

[fs, 2015/11/26 13:30:23]

IIRC, this method still gets called when there's no fragment, so I think this
should be within "if (!name.isEmpty())" or so?

[davve, 2015/11/26 13:35:37]

I only found one call-site, FrameView::processUrlFragmentHelper, with one call
site, FrameView::processUrlFragment that checks for fragment.

Adding it seems like the safer option though.

[fs, 2015/11/26 13:38:36]

Yes, in processUrlFragment we have:

    // If our URL has no ref, then we have no place we need to jump to.
    // OTOH If CSS target was set previously...
...
    // Similarly for svg, if we had a previous svgView() then we need to reset
    // the initial view if we don't have a fragment.
    if (!url.hasFragmentIdentifier() && !m_frame->document()->cssTarget() &&
!m_frame->document()->isSVGDocument())
        return false;

[davve, 2015/11/26 13:43:20]

Ouch, a !m_frame->document()->isSVGDocument() there. Thanks. Might as well add
that to the test.

+
     // Spec: If the SVG fragment identifier addresses a 'view' element within an SVG document (e.g., MyDrawing.svg#MyView
     // or MyDrawing.svg#xpointer(id('MyView'))) then the closest ancestor 'svg' element is displayed in the viewport.
     // Any view specification attributes included on the given 'view' element override the corresponding view specification
     // attributes on the closest ancestor 'svg' element.
     // TODO(ed): The spec text above is a bit unclear.
     // Should the transform from outermost svg to nested svg be applied to "display"
     // the inner svg in the viewport, then let the view element override the inner
     // svg's view specification attributes. Should it fill/override the outer viewport?
     if (isSVGViewElement(anchorNode)) {
         SVGViewElement& viewElement = toSVGViewElement(*anchorNode);
@@ skipping 45 matching lines @@
     visitor->trace(m_width);
     visitor->trace(m_height);
     visitor->trace(m_translation);
     visitor->trace(m_timeContainer);
     visitor->trace(m_viewSpec);
     SVGGraphicsElement::trace(visitor);
     SVGFitToViewBox::trace(visitor);
 }
 
 } // namespace blink