Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1471933003: Consume initial whitespace up front in CSSPropertyParser (Closed)

Created:
5 years, 1 month ago by Timothy Loh
Modified:
5 years ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consume initial whitespace up front in CSSPropertyParser This patch makes the CSSPropertyParser consume the initial whitespace at the start, instead of in each of the separate top-level parsing functions (parseShorthand, parseSingleValue, parseViewportDescriptor, parseFontFaceDescriptor). BUG=499780 Committed: https://crrev.com/b36f7565148d9505a503a71a8ade3bbd53c79f16 Cr-Commit-Position: refs/heads/master@{#361293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 5 chunks +1 line, -6 lines 0 comments Download

Dependent Patchsets:

Issue 1459633004 Patch 40001

Messages

Total messages: 19 (8 generated)
Timothy Loh
5 years ago (2015-11-24 03:15:10 UTC) #2
alancutter (OOO until 2018)
lgtm
5 years ago (2015-11-24 03:18:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471933003/1
5 years ago (2015-11-24 03:20:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133351)
5 years ago (2015-11-24 04:35:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471933003/1
5 years ago (2015-11-24 04:40:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133481)
5 years ago (2015-11-24 06:12:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471933003/1
5 years ago (2015-11-24 06:15:33 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133586)
5 years ago (2015-11-24 07:56:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471933003/1
5 years ago (2015-11-24 08:15:05 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 08:44:57 UTC) #18
commit-bot: I haz the power
5 years ago (2015-11-24 08:45:40 UTC) #19
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b36f7565148d9505a503a71a8ade3bbd53c79f16
Cr-Commit-Position: refs/heads/master@{#361293}

Powered by Google App Engine
This is Rietveld 408576698