Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1471933002: Remove unneeded LayoutObjectChildList::setFirst/LastChild (Closed)

Created:
5 years, 1 month ago by dstockwell
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded LayoutObjectChildList::setFirst/LastChild The fixme is from 2009[1]. [1] https://chromium.googlesource.com/chromium/src/+/eac8e63e693333ed390be4ae74ac15295c9f95d8 Committed: https://crrev.com/d5f70f6989efc581656baff3ce094f19b6a27921 Cr-Commit-Position: refs/heads/master@{#361288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObjectChildList.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
dstockwell
5 years, 1 month ago (2015-11-23 22:53:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471933002/1
5 years, 1 month ago (2015-11-23 22:55:17 UTC) #4
rune
lgtm
5 years, 1 month ago (2015-11-23 23:31:56 UTC) #6
Julien - ping for review
lgtm2, awesome!
5 years, 1 month ago (2015-11-24 00:18:06 UTC) #7
Julien - ping for review
On 2015/11/24 at 00:18:06, Julien Chaffraix - PST wrote: > lgtm2, awesome! lgtm 2 (really)
5 years, 1 month ago (2015-11-24 00:18:26 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133151)
5 years ago (2015-11-24 01:14:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471933002/1
5 years ago (2015-11-24 01:27:10 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133330)
5 years ago (2015-11-24 04:12:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471933002/1
5 years ago (2015-11-24 05:41:54 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133562)
5 years ago (2015-11-24 07:17:10 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471933002/1
5 years ago (2015-11-24 07:55:39 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 08:29:02 UTC) #21
commit-bot: I haz the power
5 years ago (2015-11-24 08:29:38 UTC) #22
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d5f70f6989efc581656baff3ce094f19b6a27921
Cr-Commit-Position: refs/heads/master@{#361288}

Powered by Google App Engine
This is Rietveld 408576698