Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 1471913005: Merge to M47: Add a missing setjmp() to CCodec_JpegDecoder::v_GetNextLine(). (Closed)

Created:
5 years ago by Oliver Chang
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@2526
Target Ref:
refs/heads/chromium/2526
Visibility:
Public.

Description

Merge to M47: Add a missing setjmp() to CCodec_JpegDecoder::v_GetNextLine(). If jpeg_read_scanlines() ends up calling the error callback, we longjmp into some undefined state. BUG=558840 TBR=thestig@chromium.org Original Review URL: https://codereview.chromium.org/1463563003 . (cherry picked from commit 06e33aec03f13c76d9eff5c09cb03e142b0c5ef1) Committed: https://pdfium.googlesource.com/pdfium/+/9c2b4ad8e3bfb3e748874bdfda3f265f0972cfd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M core/src/fxcodec/codec/fx_codec_jpeg.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Oliver Chang
TBR. minor conflict since https://pdfium.googlesource.com/pdfium.git/+/3d59bd9d66d01eb39c30742bce67fa0376cb4ea8 isn't in M47
5 years ago (2015-11-24 20:30:19 UTC) #1
Oliver Chang
Committed patchset #1 (id:1) manually as 9c2b4ad8e3bfb3e748874bdfda3f265f0972cfd6 (presubmit successful).
5 years ago (2015-11-24 20:35:05 UTC) #2
Lei Zhang
5 years ago (2015-11-24 21:10:57 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698