Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Issue 1471883003: Added code and key to KeyboardEventInit (Closed)

Created:
5 years ago by chongz
Modified:
5 years ago
Reviewers:
dtapuska, Rick Byers
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added code and key to KeyboardEventInit Since [RuntimeEnabled=KeyboardEventKey] readonly attribute DOMString key; [RuntimeEnabled=KeyboardEventCode] readonly attribute DOMString code; we can pass code and key in KeyboardEventInit but won't be able to access it unless the flags are enabled. code and key are supported in Firefox BUG=327853 Committed: https://crrev.com/ec4421ab094294f7c13f21d91c1ab56c6cba068e Cr-Commit-Position: refs/heads/master@{#362025}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Make code/key RuntimeEnabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -24 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor.html View 2 chunks +49 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt View 2 chunks +39 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/events/KeyboardEvent.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/KeyboardEventInit.idl View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
chongz
5 years ago (2015-11-24 19:43:49 UTC) #3
dtapuska
https://codereview.chromium.org/1471883003/diff/1/third_party/WebKit/Source/core/events/KeyboardEventInit.idl File third_party/WebKit/Source/core/events/KeyboardEventInit.idl (right): https://codereview.chromium.org/1471883003/diff/1/third_party/WebKit/Source/core/events/KeyboardEventInit.idl#newcode8 third_party/WebKit/Source/core/events/KeyboardEventInit.idl:8: DOMString key = ""; These should be runtime enabled ...
5 years ago (2015-11-24 19:50:45 UTC) #4
chongz
Added RuntimeEnabled label to code/key, since code is stable and key is experimental the test ...
5 years ago (2015-11-25 17:32:35 UTC) #5
dtapuska
On 2015/11/25 17:32:35, chongz wrote: > Added RuntimeEnabled label to code/key, since code is stable ...
5 years ago (2015-11-25 18:00:58 UTC) #6
chongz
5 years ago (2015-11-25 19:59:08 UTC) #8
Rick Byers
LGTM
5 years ago (2015-11-27 02:47:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471883003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471883003/20001
5 years ago (2015-11-27 16:49:41 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-27 18:06:41 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-27 18:07:21 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ec4421ab094294f7c13f21d91c1ab56c6cba068e
Cr-Commit-Position: refs/heads/master@{#362025}

Powered by Google App Engine
This is Rietveld 408576698