Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1471833002: Stop using base::IDMap in the NotificationPermissionDispatcher (Closed)

Created:
5 years, 1 month ago by Peter Beverloo
Modified:
5 years ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop using base::IDMap in the NotificationPermissionDispatcher BUG= Committed: https://crrev.com/a59ee43b91e311d1de628f075e80e2374ad1b5e1 Cr-Commit-Position: refs/heads/master@{#361310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M content/renderer/notification_permission_dispatcher.h View 3 chunks +7 lines, -10 lines 0 comments Download
M content/renderer/notification_permission_dispatcher.cc View 2 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Peter Beverloo
+mvanouwerkerk
5 years, 1 month ago (2015-11-23 17:52:01 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 1 month ago (2015-11-23 18:09:13 UTC) #3
Peter Beverloo
+avi Slightly tangential, but I'd like to own this file. Would you prefer I add ...
5 years, 1 month ago (2015-11-23 18:52:47 UTC) #5
Avi (use Gerrit)
If there are enough to move to their own directory, go for it. Either way, ...
5 years, 1 month ago (2015-11-23 22:36:45 UTC) #6
Avi (use Gerrit)
Oh, LGTM.
5 years, 1 month ago (2015-11-23 22:36:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471833002/1
5 years ago (2015-11-24 10:25:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 10:55:19 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-24 10:56:17 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a59ee43b91e311d1de628f075e80e2374ad1b5e1
Cr-Commit-Position: refs/heads/master@{#361310}

Powered by Google App Engine
This is Rietveld 408576698