Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1471823002: PPC: [stubs] Change CallICStub to utilize the ConvertReceiverMode. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [stubs] Change CallICStub to utilize the ConvertReceiverMode. Port d80fd48e5d3d401c10ce95cf8430e5caa9984e32 Original commit message: The CallICStub has call-site specific knowledge about the receiver, which we did not utilize; plus the CallICStub does in some case know whether it is about to [[Call]] a function or potentially some other callable. In the common case we actually know that the target is a function and so we can use the CallFunction builtin directly instead of redispatching in the Call builtin. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:555127, v8:4413 LOG=n Committed: https://crrev.com/ee72c4079cbabb52ab424998203e959da7235f68 Cr-Commit-Position: refs/heads/master@{#32185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/ppc/code-stubs-ppc.cc View 4 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years ago (2015-11-23 17:48:57 UTC) #1
JoranSiu
On 2015/11/23 17:48:57, mtbrandyberry wrote: lgtm
5 years ago (2015-11-23 18:36:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471823002/1
5 years ago (2015-11-23 19:41:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-23 20:00:53 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-23 20:01:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee72c4079cbabb52ab424998203e959da7235f68
Cr-Commit-Position: refs/heads/master@{#32185}

Powered by Google App Engine
This is Rietveld 408576698