services/media/audio/platform/linux/alsa_output.h - Issue 1471813002: Mix to an intermediate buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/media/audio/platform/linux/alsa_output.h

Issue 1471813002: Mix to an intermediate buffer. (Closed) Base URL: https://github.com/domokit/mojo.git@change7

Patch Set: Final rebase before landing Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/media/audio/platform/linux/alsa_output.h

diff --git a/services/media/audio/platform/linux/alsa_output.h b/services/media/audio/platform/linux/alsa_output.h

index 1da2ca27de2c16d856ec3a1ea4fc94183e524462..8c176135e649dfa28e5f32e82ea02e1566ef07bf 100644

--- a/services/media/audio/platform/linux/alsa_output.h

+++ b/services/media/audio/platform/linux/alsa_output.h

@@ -36,7 +36,6 @@ class AlsaOutput : public StandardOutputBase {

bool FinishMixJob(const MixJob& job) override;

private:

- void FillMixBufWithSilence(uint32_t frames);

void HandleAlsaError(snd_pcm_sframes_t code);

void HandleAsError(snd_pcm_sframes_t code);

void HandleAsUnderflow();

@@ -45,7 +44,6 @@ class AlsaOutput : public StandardOutputBase {

snd_pcm_format_t alsa_format_;

LinearTransform::Ratio frames_per_tick_;

- uint8_t silence_byte_;

std::unique_ptr<uint8_t> mix_buf_;

uint32_t mix_buf_frames_;