services/media/audio/platform/generic/mixers/no_op.h - Issue 1471813002: Mix to an intermediate buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/media/audio/platform/generic/mixers/no_op.h

Issue 1471813002: Mix to an intermediate buffer. (Closed) Base URL: https://github.com/domokit/mojo.git@change7

Patch Set: Final rebase before landing Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/media/audio/platform/generic/mixers/no_op.h

diff --git a/services/media/audio/platform/generic/mixers/no_op.h b/services/media/audio/platform/generic/mixers/no_op.h

index 5467c24cc3d3d27801bfa85c960872291116a6ce..ac51f9ba6dd24fca964c824fd2255d1fd15c520b 100644

--- a/services/media/audio/platform/generic/mixers/no_op.h

+++ b/services/media/audio/platform/generic/mixers/no_op.h

@@ -16,7 +16,7 @@ class NoOp : public Mixer {

public:

NoOp() : Mixer(0, 0) {}

- bool Mix(void* dst,

+ bool Mix(int32_t* dst,

uint32_t dst_frames,

uint32_t* dst_offset,

const void* src,