services/media/audio/platform/generic/mixers/no_op.cc - Issue 1471813002: Mix to an intermediate buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/media/audio/platform/generic/mixers/no_op.cc

Issue 1471813002: Mix to an intermediate buffer. (Closed) Base URL: https://github.com/domokit/mojo.git@change7

Patch Set: rebase on top of samples_per_frame -> channels patchset Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/media/audio/platform/generic/mixers/no_op.cc

diff --git a/services/media/audio/platform/generic/mixers/no_op.cc b/services/media/audio/platform/generic/mixers/no_op.cc

index 03530c6d0187af5e8fef5f47355f0ef9dd4025fa..493c7db9225c7a9e30188c3dbe8c6f23cdd842a5 100644

--- a/services/media/audio/platform/generic/mixers/no_op.cc

+++ b/services/media/audio/platform/generic/mixers/no_op.cc

@@ -11,7 +11,7 @@ namespace media {

namespace audio {

namespace mixers {

-bool NoOp::Mix(void* dst,

+bool NoOp::Mix(int32_t* dst,

uint32_t dst_frames,

uint32_t* dst_offset,

const void* src,