Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: services/media/audio/platform/generic/mixer.h

Issue 1471813002: Mix to an intermediate buffer. (Closed) Base URL: https://github.com/domokit/mojo.git@change7
Patch Set: rebase on top of samples_per_frame -> channels patchset Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/media/audio/platform/generic/mixer.h
diff --git a/services/media/audio/platform/generic/mixer.h b/services/media/audio/platform/generic/mixer.h
index 1f4a1e2bb8ba2680dfa6a303a61dbb8e7481eacc..09bbefe68cbc7347124ef4ce361bb9484676e7f6 100644
--- a/services/media/audio/platform/generic/mixer.h
+++ b/services/media/audio/platform/generic/mixer.h
@@ -35,7 +35,7 @@ class Mixer {
// interpolation sampler, the user may actually prefer cubic interpolation, or
// perhaps just a point sampler.
static MixerPtr Select(const LpcmMediaTypeDetailsPtr& src_format,
- const LpcmMediaTypeDetailsPtr& dst_format);
+ const LpcmMediaTypeDetailsPtr* dst_format);
// Mix
//
@@ -88,7 +88,7 @@ class Mixer {
// @return True if the mixer is finished with this source data and will not
// need it in the future. False if the mixer has not consumed the entire
// source buffer and will need more of it in the future.
- virtual bool Mix(void* dst,
+ virtual bool Mix(int32_t* dst,
uint32_t dst_frames,
uint32_t* dst_offset,
const void* src,

Powered by Google App Engine
This is Rietveld 408576698